Feedback-ID: ia2694551:Fastmail
Date: Tue, 30 Aug 2022 11:20:08 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>,
	Andrew Dunstan <andrew@dunslane.net>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	John Naylor <john.naylor@enterprisedb.com>
Subject: Re: SQL/JSON features for v15
Message-ID: <20220830092008.6dbublx6la226zis@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+HiwqH8gTp2uNN3QtgeOSgHhZUZz1=0U+JObJJUmEoch_269Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220830092008.6dbublx6la226zis%40alvherre.pgsql>
Precedence: bulk

On 2022-Aug-30, Amit Langote wrote:

> Patches 0001-0006:
> 
> Yeah, these add the overhead of an extra function call (typin() ->
> typin_opt_error()) in possibly very common paths.  Other than
> refactoring *all* places that call typin() to use the new API, the
> only other option seems to be to leave the typin() functions alone and
> duplicate their code in typin_opt_error() versions for all the types
> that this patch cares about.  Though maybe, that's not necessarily a
> better compromise than accepting the extra function call overhead.

I think another possibility is to create a static inline function in the
corresponding .c module (say boolin_impl() in bool.c), which is called
by both the opt_error variant as well as the regular one.  This would
avoid the duplicate code as well as the added function-call overhead.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Syntax error: function hell() needs an argument.
Please choose what hell you want to involve.