Date: Tue, 30 Aug 2022 21:17:12 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Jelte Fennema <Jelte.Fennema@microsoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Merlin Moncure <mmoncure@gmail.com>,
	Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: [PATCH] Optimize json_lex_string by batching character copying
Message-ID: <20220831041712.GA640362@nathanxps13>
References: 
 <CAFBsxsESLUyJ5spfOSyPrOvKUEYYNqsBosue9SV1j8ecgNXSKA@mail.gmail.com>
 <20220815212304.GA251709@nathanxps13>
 <CAFBsxsF8asF=qa2toXOceBgAYoKtftkL7tmE-WmCWxW-CRkeQg@mail.gmail.com>
 <20220819204215.GA397534@nathanxps13>
 <20220821054733.GA780295@nathanxps13>
 <CAFBsxsH93DNy=x5Jiu37qFRyq==kz0fJbGjx835ZFyj-DMSXuw@mail.gmail.com>
 <20220822212229.GA1129243@nathanxps13>
 <20220823033236.GA1204962@nathanxps13>
 <CAFBsxsEDR6GctRTayurcGyR6d3GDjv0XGBqArPvrbO3H38T6Jg@mail.gmail.com>
 <CAFBsxsEcr5H8ydKR66VZeJo8buwScOsHX71z5KVcdvmx=YDC9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFBsxsEcr5H8ydKR66VZeJo8buwScOsHX71z5KVcdvmx=YDC9g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220831041712.GA640362%40nathanxps13>
Precedence: bulk

On Wed, Aug 31, 2022 at 10:50:39AM +0700, John Naylor wrote:
> Here's the final piece. I debated how many tests to add and decided it
> was probably enough to add one each for checking quotes and
> backslashes in the fast path. There is one cosmetic change in the
> code: Before, the vectorized less-equal check compared to 0x1F, but
> the byte-wise path did so with < 32. I made them both "less-equal 31"
> for consistency. I'll commit this by the end of the week unless anyone
> has a better idea about testing.

LGTM

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com