Date: Wed, 31 Aug 2022 12:24:28 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Avoid erroring out when unable to remove or parse logical
 rewrite files to save checkpoint work
Message-ID: <20220831192428.GA641777@nathanxps13>
References: 
 <CALj2ACVd0ukptEi5pFyeEx-nw_C9jTRvtQJvQpm0BUhOCvrH0g@mail.gmail.com>
 <CA+hUKGL30BKpudMLYP++hTvK+O5DirMkwEg6yWQ9BLycKfPUvw@mail.gmail.com>
 <CALj2ACWSjE8AiJ4xaBS4ULQ8T6RevwsNhTD6yPBLugJBTD5LCw@mail.gmail.com>
 <20220816203233.GA255076@nathanxps13>
 <CALj2ACXZPMYXrPZ+CUE0_5DKDnxyqDGRftSgPPx--PWhWB3RtQ@mail.gmail.com>
 <20220823180744.GD1207981@nathanxps13>
 <CALj2ACX0TW4C8gtwFMjyG2r=xnbRUnO5uRWQVscJoZFD208U_g@mail.gmail.com>
 <YwdpW20yC6pMs6fQ@paquier.xyz>
 <CALj2ACV2boDSpQGYvp5Won6qfJgwdpeFMJTO-4Z7dKZy8UAH2Q@mail.gmail.com>
 <20220831191433.ruqbhu2ady4qrdpv@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220831191433.ruqbhu2ady4qrdpv@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20220831192428.GA641777%40nathanxps13>
Precedence: bulk

On Wed, Aug 31, 2022 at 12:14:33PM -0700, Andres Freund wrote:
> On 2022-08-27 14:06:32 +0530, Bharath Rupireddy wrote:
>> -		if (lstat(fromfile, &fst) < 0)
>> -			ereport(ERROR,
>> -					(errcode_for_file_access(),
>> -					 errmsg("could not stat file \"%s\": %m", fromfile)));
>> +		xlde_type = get_dirent_type(fromfile, xlde, false, ERROR);
>>  
>> -		if (S_ISDIR(fst.st_mode))
>> +		if (xlde_type == PGFILETYPE_DIR)
>>  		{
>>  			/* recurse to handle subdirectories */
>>  			if (recurse)
>>  				copydir(fromfile, tofile, true);
>>  		}
>> -		else if (S_ISREG(fst.st_mode))
>> +		else if (xlde_type == PGFILETYPE_REG)
>>  			copy_file(fromfile, tofile);
>>  	}
>>  	FreeDir(xldir);
> 
> It continues to make no sense to me to add behaviour changes around
> error-handling as part of a conversion to get_dirent_type(). I don't at all
> understand why e.g. the above change to make copydir() silently skip over
> files it can't stat is ok?

In this example, the call to get_dirent_type() should ERROR if the call to
lstat() fails (the "elevel" argument is set to ERROR).
-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com