Date: Thu, 8 Sep 2022 08:29:20 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Daniel Gustafsson <daniel@yesql.se>,
	Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Message-ID: <20220908132920.GG31833@telsasoft.com>
References: <YsU5fb0ceDADr2Ti@paquier.xyz>
 <CA+hUKGL1p7BHdZc_GEBYkLarPzFEAYKd_HXA_NJ_ct4dJCD-iw@mail.gmail.com>
 <503cc622-ea4d-0a78-ff0c-2c757b97149e@dunslane.net>
 <YsYkzVnFpV79ZTXU@paquier.xyz>
 <YsZnhwERsDv/LtC7@paquier.xyz>
 <20220826112637.GD2342@telsasoft.com>
 <YwmtHRRoA5gQi7lZ@paquier.xyz>
 <Yw1gZjJjS3BNTlim@paquier.xyz>
 <CA+hUKG+BMdcaCe=P-EjMoLTCr3zrrzqbcVE=8h5LyNsSVHKXZA@mail.gmail.com>
 <YxmuDClnF90gAxxW@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxmuDClnF90gAxxW@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220908132920.GG31833%40telsasoft.com>
Precedence: bulk

On Thu, Sep 08, 2022 at 05:55:40PM +0900, Michael Paquier wrote:
> On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> > This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> > a direct function call.  Can you just call all these functions
> > directly these days?
> 
> Hmm.  Some tests in the CI show that attempting to call directly
> MiniDumpWriteDump() causes a linking failure at compilation.  Anyway,
> in the same fashion, I can get some simplifications done right for
> pg_ctl.c, auth.c and restricted_token.c.  And I am seeing all these
> functions listed in the headers of MinGW, meaning that all these
> should work out of the box in this case, no?
> 
> The others are library-dependent, and I not really confident about
> ldap_start_tls_sA().  So, at the end, I am finishing with the
> attached, what do you think?  This cuts some code, which is nice:
>  3 files changed, 48 insertions(+), 159 deletions(-)

+1

It seems silly to do it at runtime if it's possible to do it at link time.

-- 
Justin