Date: Fri, 9 Sep 2022 11:46:25 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	Daniel Verite <daniel@manitou-mail.org>, AndrewBille@gmail.com,
	michael@paquier.xyz
Subject: Re: ICU for global collation
Message-ID: <20220909164625.GN31833@telsasoft.com>
References: <20220628013205.GH19662@telsasoft.com>
 <f385ba25e7f8be427b8c582e5cca7d79@postgrespro.ru>
 <7d74b2d7-7fc6-f55b-3f77-c0e05569b64e@enterprisedb.com>
 <YwRUn4J8+uqlyUYQ@paquier.xyz>
 <7ad26354e75259f59c4a6c6997b8ee32@postgrespro.ru>
 <YwWrVEDpLNGFA4Mq@paquier.xyz>
 <20220824085923.jro5ao2m5b4mdll5@jrouhaud>
 <13468bee-a5b4-65aa-932c-c12584f4458d@enterprisedb.com>
 <Yw4KoBm1mS+2xzIj@paquier.xyz>
 <7c99c132dc9c0ac630e0127f032ac480@postgrespro.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7c99c132dc9c0ac630e0127f032ac480@postgrespro.ru>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220909164625.GN31833%40telsasoft.com>
Precedence: bulk

In pg14:
|postgres=# create database a LC_COLLATE C LC_CTYPE C LOCALE C;
|ERROR:  conflicting or redundant options
|DETAIL:  LOCALE cannot be specified together with LC_COLLATE or LC_CTYPE.

In pg15:
|postgres=# create database a LC_COLLATE "en_US.UTF-8" LC_CTYPE "en_US.UTF-8" LOCALE "en_US.UTF-8" ;
|CREATE DATABASE

f2553d430 actually relaxed the restriction by removing this check:

-       if (dlocale && (dcollate || dctype))
-               ereport(ERROR,
-                               (errcode(ERRCODE_SYNTAX_ERROR),
-                                errmsg("conflicting or redundant options"),
-                                errdetail("LOCALE cannot be specified together with LC_COLLATE or LC_CTYPE.")));

But isn't the right fix to do the corresponding thing in createdb
(relaxing the frontend restriction rather than reverting its relaxation
in the backend).

diff --git a/src/bin/scripts/createdb.c b/src/bin/scripts/createdb.c
index e523e58b218..5b80e56dfd9 100644
--- a/src/bin/scripts/createdb.c
+++ b/src/bin/scripts/createdb.c
@@ -159,15 +159,10 @@ main(int argc, char *argv[])
 			exit(1);
 	}
 
-	if (locale)
-	{
-		if (lc_ctype)
-			pg_fatal("only one of --locale and --lc-ctype can be specified");
-		if (lc_collate)
-			pg_fatal("only one of --locale and --lc-collate can be specified");
+	if (locale && !lc_ctype)
 		lc_ctype = locale;
+	if (locale && !lc_collate)
 		lc_collate = locale;
-	}
 
 	if (encoding)
 	{


BTW it's somewhat crummy that it uses a string comparison, so if you
write "UTF8" without a dash, it says this; it took me a few minutes to
see the difference...

postgres=# create database a LC_COLLATE "en_US.UTF8" LC_CTYPE "en_US.UTF8" LOCALE "en_US.UTF8";
ERROR:  new collation (en_US.UTF8) is incompatible with the collation of the template database (en_US.UTF-8)