Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY1wi-0001KZ-Sd for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 09:11:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oY1vi-0007gA-US for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 09:10:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY1vi-0007fz-Ku for pgsql-hackers@lists.postgresql.org; Tue, 13 Sep 2022 09:10:06 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY1vf-0001ur-Rs for pgsql-hackers@lists.postgresql.org; Tue, 13 Sep 2022 09:10:05 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D24BC5C018B; Tue, 13 Sep 2022 05:10:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 13 Sep 2022 05:10:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1663060202; x=1663146602; bh=k mqrJgDC5g8oMlZ6UVRdsXoeRR3Ga5J16cbSvm8SuYA=; b=KeF7XgKAvWbMlsrMO lxkQKvMBwzHemMO46HA1VrUFB4aehSd9gqE/IjW5NOdlw5Z2RolAJcNPLfqm4IWU Y7YqCEcrWW9GoPi+cy5iatzlb4m2Mk1/9d8Pf6WdHUsORPjVk+XLBEtcvj6eGbbk CEnJFHJLNfnijkI514sz8HDPB0McAHciYVbu2shxDgJG083+2aHUpmlCsm3Q8WjS DLFIEXTzd8MRqzSa8F8kqL1PCVJXEALpuclwHi4ri6RWyrHelnCoM0xldYnpCN0L 1N182FLdMBDgNRNR2dDrFtwQ6UFbK9avvLk2xMsXexC6ARpNVxkyL0SSMIsWRZ1K Entwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Sep 2022 05:10:01 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 23B9138C; Tue, 13 Sep 2022 11:10:00 +0200 (CEST) Date: Tue, 13 Sep 2022 11:10:00 +0200 From: Alvaro Herrera To: Tom Lane Cc: Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= , Andres Freund , Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: Splitting up guc.c Message-ID: <20220913091000.l4dam6w5euja3pua@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1778776.1663014026@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Sep-12, Tom Lane wrote: > Yeah, I suspect people will have to manually reapply any changes in > the GUC tables to guc_tables.c. That'll be the same amount of work > for them whenever we commit this patch (unless theirs lands first, > in which case I have to deal with it). The issue I think is > whether it's politer to make that happen during a CF or between > CFs. Personally I would prefer that this kind of thing is done quickly rather than delay it to some uncertain future. That way I can deal with it straight ahead rather than living with the anxiety that it will land later and I will have to deal with it then. I see no benefit in waiting. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/