Date: Wed, 14 Sep 2022 13:03:05 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Benoit =?iso-8859-1?Q?Lobr=E9au?= <benoit.lobreau@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Message-ID: <20220914200305.GA2984249@nathanxps13>
References: 
 <CAPE8EZ7vh6gdgHjAYhuvjUJzvZm7PGeZQaDDBfSYmDmfa+QeFg@mail.gmail.com>
 <20220824221723.GA1347845@nathanxps13>
 <CAPE8EZ4F3d06diQ27D=5qxN2FVHA0qsaRghzkLDf=KZHEUN7rg@mail.gmail.com>
 <20220825200600.GA1465148@nathanxps13>
 <20220829224621.GB541895@nathanxps13>
 <CAPE8EZ7SQKKkreVT2Cjrheg8dChT_qSDRBS71r-r+girEMQ4bw@mail.gmail.com>
 <20220830163048.GA544233@nathanxps13>
 <613541.1662842656@sss.pgh.pa.us>
 <20220910211046.GA2651323@nathanxps13>
 <9ee5d180-2c32-a1ca-d3d7-63a723f68d9a@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9ee5d180-2c32-a1ca-d3d7-63a723f68d9a@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220914200305.GA2984249%40nathanxps13>
Precedence: bulk

On Wed, Sep 14, 2022 at 09:33:46PM +0200, Peter Eisentraut wrote:
> Another question on this feature: Currently, if archive_library is set,
> archive_command is ignored.  I think if both are set, it should be an error.
> Compare for example what happens if you set multiple recovery_target_xxx
> settings.  I don't think silently turning off one setting by setting another
> is a good behavior.

I originally did it this way, but changed it based on this feedback [0].  I
have no problem with the general idea, but the recovery_target_* logic does
have the following note:

	 * XXX this code is broken by design.  Throwing an error from a GUC assign
	 * hook breaks fundamental assumptions of guc.c.  So long as all the variables
	 * for which this can happen are PGC_POSTMASTER, the consequences are limited,
	 * since we'd just abort postmaster startup anyway.  Nonetheless it's likely
	 * that we have odd behaviors such as unexpected GUC ordering dependencies.

[0] https://postgr.es/m/CA%2BTgmoaf4Y7_U%2B_W%2BSg5DoAta_FMssr%3D52mx7-_tJnfaD1VubQ%40mail.gmail.com

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com