Date: Fri, 23 Sep 2022 09:14:02 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Benoit =?iso-8859-1?Q?Lobr=E9au?= <benoit.lobreau@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Message-ID: <20220923161402.GA736566@nathanxps13>
References: <613541.1662842656@sss.pgh.pa.us>
 <20220910211046.GA2651323@nathanxps13>
 <9ee5d180-2c32-a1ca-d3d7-63a723f68d9a@enterprisedb.com>
 <20220914200305.GA2984249@nathanxps13>
 <37857474-5caa-ccb3-92a3-150ddfe851ab@enterprisedb.com>
 <2884265.1663188443@sss.pgh.pa.us>
 <20220914211746.GA2986134@nathanxps13>
 <2910705.1663193529@sss.pgh.pa.us>
 <20220914222736.GA3042279@nathanxps13>
 <d9d1f7fd-dd99-98f9-8aed-0e976921573b@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d9d1f7fd-dd99-98f9-8aed-0e976921573b@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220923161402.GA736566%40nathanxps13>
Precedence: bulk

On Fri, Sep 23, 2022 at 05:58:42AM -0400, Peter Eisentraut wrote:
> On 15.09.22 00:27, Nathan Bossart wrote:
>> Both archive_command and archive_library are PGC_SIGHUP, so IIUC that
>> wouldn't be sufficient.  I attached a quick sketch that seems to provide
>> the desired behavior.  It's nowhere near committable yet, but it
>> demonstrates what I'm thinking.
> 
> What is the effect of issuing a warning like in this patch?  Would it just
> not archive anything until the configuration is fixed?  I'm not sure what
> behavior you are going for; it's a bit hard to imagine from just reading the
> patch.

Yes, it will halt archiving and emit a WARNING, just like what happens on
released versions when you leave archive_command empty.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com