Date: Sat, 24 Sep 2022 16:07:14 +0200
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Zhihong Yu <zyu@yugabyte.com>,
	David Steele <david@pgmasters.net>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Greg Stark <stark@mit.edu>,
	Pavel Trukhanov <pavel.trukhanov@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_stat_statements and "IN" conditions
Message-ID: <20220924140714.irgoytcu2wacdl2i@ddolgov.remote.csb>
References: 
 <CA+TgmoYG+nL1-3xmejYx-dm__7JMpCaptYkCVernS7wrriHQ+w@mail.gmail.com>
 <20220314145734.x3re4hcr6ukmppwi@ddolgov.remote.csb>
 <CA+Tgmob74W5+Da9a=95sRz2EXA221tMHzJ4tNUH5yWyt5Td5aw@mail.gmail.com>
 <178940.1647271397@sss.pgh.pa.us>
 <20220314153346.6chynq26mcypxaco@ddolgov.remote.csb>
 <180607.1647272303@sss.pgh.pa.us>
 <20220314155150.mgitoto7e5jkqilb@ddolgov.remote.csb>
 <20220326174035.2vwhtof6ow7kib7n@erthalion.local>
 <20220724100636.do3nt7f73d7zbrfx@erthalion.local>
 <2709541663352713@prvcgftslwhsg7ig.myt.yp-c.yandex.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2709541663352713@prvcgftslwhsg7ig.myt.yp-c.yandex.net>
Archived-At: 
 <https://www.postgresql.org/message-id/20220924140714.irgoytcu2wacdl2i%40ddolgov.remote.csb>
Precedence: bulk

> On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> Hello!
>
> Unfortunately the patch needs another rebase due to the recent split of guc.c (0a20ff54f5e66158930d5328f89f087d4e9ab400)
>
> I'm reviewing a patch on top of a previous commit and noticed a failed test:
>
> #   Failed test 'no parameters missing from postgresql.conf.sample'
> #   at t/003_check_guc.pl line 82.
> #          got: '1'
> #     expected: '0'
> # Looks like you failed 1 test of 3.
> t/003_check_guc.pl ..............
>
> The new option has not been added to the postgresql.conf.sample
>
> PS: I would also like to have such a feature. It's hard to increase pg_stat_statements.max or lose some entries just because some ORM sends requests with a different number of parameters.

Thanks! I'll post the rebased version soon.