Date: Mon, 26 Sep 2022 17:29:58 +0900 (JST)
Message-Id: <20220926.172958.1790193605025533956.horikyota.ntt@gmail.com>
To: pryzby@telsasoft.com
Cc: michael@paquier.xyz, andres@anarazel.de, nathandbossart@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20220918045306.GT31833@telsasoft.com>
References: <20220728222734.GA1913@telsasoft.com>
	<20220913004303.GM31833@telsasoft.com>
	<20220918045306.GT31833@telsasoft.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20220926.172958.1790193605025533956.horikyota.ntt%40gmail.com>
Precedence: bulk

At Sat, 17 Sep 2022 23:53:07 -0500, Justin Pryzby <pryzby@telsasoft.com> wrote in 
> This is an alternative implementation, which still relies on adding the
> GUC_DYNAMIC, flag but doesn't require adding a new, sql-accessible
> function to convert the GUC to a pretty/human display value.

Thanks!

I'm not sure shared_buffer is GUC_DYNAMIC_DEFAULT, and we need to read
postgresql.conf.sample using SQL, but +1 for the direction.

+	AND NOT (sc.sample_value ~ '^0' AND current_setting(name) ~ '^0') -- zeros may be written differently
+	AND NOT (sc.sample_value='60s' AND current_setting(name) = '1min') -- two ways to write 1min

Mmm. Couldn't we get away from that explicit exceptions?


regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center