Date: Tue, 27 Sep 2022 12:34:25 +0900 (JST)
Message-Id: <20220927.123425.211849117477195012.horikyota.ntt@gmail.com>
To: masao.fujii@oss.nttdata.com
Cc: bt22nakamorit@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <a56cb988-975d-e240-15d5-a7bd11ccc413@oss.nttdata.com>
References: <4c61d434cb72b2237b3279797b2a387f@oss.nttdata.com>
	<8a022f2c8de93ea79116f0b7eb42248a@oss.nttdata.com>
	<a56cb988-975d-e240-15d5-a7bd11ccc413@oss.nttdata.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20220927.123425.211849117477195012.horikyota.ntt%40gmail.com>
Precedence: bulk

At Wed, 21 Sep 2022 11:45:07 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in 
> 
> 
> On 2022/09/20 15:15, bt22nakamorit wrote:
> >>>> I thought that this action is rather unexpected since, based on the
> >>>> word """ON_ERROR_STOP""", ones may expect that failures of shell
> >>>> scripts should halt the incoming instructions as well.
> >>>> One clear solution is to let failures of shell script stop incoming
> >>>> queries just like how errors of SQLs do currently. Thoughts?
> 
> +1
> 
> 
> > I edited the documentation for ON_ERROR_STOP.
> > Any other suggestions?
> 
> Thanks for the patch!
> Could you add it to the next CommitFest so that we don't forget it?
> 
> 
> We can execute the shell commands via psql in various ways
> other than \! meta-command. For example,
> 
> * `command`
> * \g | command
> * \gx | command
> * \o | command
> * \w | command
> * \copy ... program 'command'
> 
> ON_ERROR_STOP should handle not only \! but also all the above in the
> same way?

+1

> One concern about this patch is that some applications already depend
> on
> the current behavior of ON_ERROR_STOP, i.e., psql doesn't stop even
> when
> the shell command returns non-zero exit code. If so, we might need to
> extend ON_ERROR_STOP so that it accepts the following setting values.
> 
> * off - don't stop even when either sql or shell fails (same as the
> * current behavior)
> * on or sql - stop only whensql fails (same as the current behavior)
> * shell - stop only when shell fails
> * all - stop when either sql or shell fails
> 
> Thought?

+1

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center