Date: Wed, 28 Sep 2022 11:50:34 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>, Stephen Frost <sfrost@snowman.net>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Message-ID: <20220928185034.GA1397229@nathanxps13>
References: <20220907221103.GA2095022@nathanxps13>
 <CAOuzzgr60X+pnVphekO=WnAwGo9pTbo9ZG_GK4nFaR=Dxqd1hg@mail.gmail.com>
 <CA+TgmoaQExEDdRmQsFCd955dxCypDBeA_FOrUKCLNWAdQ69zxg@mail.gmail.com>
 <20220920035147.GA114383@nathanxps13>
 <YylTkIwvWuYJkMnT@paquier.xyz>
 <20220920180533.GA205278@nathanxps13>
 <20220920233117.GA378596@nathanxps13>
 <20220920235010.GB378596@nathanxps13>
 <Yyppg/c4SB7s1IAv@paquier.xyz>
 <20220921043126.GA382738@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220921043126.GA382738@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20220928185034.GA1397229%40nathanxps13>
Precedence: bulk

On Tue, Sep 20, 2022 at 09:31:26PM -0700, Nathan Bossart wrote:
> I bet a more pressing concern is the calls to aclmask() since checking
> privileges is probably done more frequently than updating them.  That
> appears to use a linear search, too, so maybe sorting the aclitem arrays is
> actually worth exploring.  I still doubt there will be much noticeable
> impact from expanding AclMode outside of the most extreme cases.

I've been testing aclmask() with long aclitem arrays (2,000 entries is
close to the limit for pg_class entries), and I haven't found any
significant impact from bumping AclMode to 64 bits.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com