Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odlW5-0001bA-6T for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Sep 2022 04:51:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1odlW4-0004RC-4P for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Sep 2022 04:51:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odlW3-0004R2-R7 for pgsql-hackers@lists.postgresql.org; Thu, 29 Sep 2022 04:51:19 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1odlVx-0006FS-8k for pgsql-hackers@lists.postgresql.org; Thu, 29 Sep 2022 04:51:18 +0000 Received: by mail-pj1-x102a.google.com with SMTP id l9-20020a17090a4d4900b00205e295400eso269980pjh.4 for ; Wed, 28 Sep 2022 21:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date; bh=GgdJiDF0VLPQbNAyYcFpOP72gRQboKkP7dhdfaG4z0I=; b=fXRA9uXPN1seTk59/DOIRfiSrf9wriDCuzAP8oWc3dhHj2j0mcCg7SJr01HokE4+H1 Epr7SGYWPORmc6wA0MVJGPH8lvQND4ouTBLl/GVXvRjcwJIOfVU5sx2AGH/a1GlDdHT6 nnF4X7qN3N2hs0OL38x3UjJxDui/VS5ui7FLL6vrC72l4Nq8oyVKMtJHzuOM5xk8X3yC id+T/72MEI8CbAmwPHu4pglhJRkus9bpdZfhG9CaNdnVGlbdnK7eUAv0obMrg7cn/ZB+ 9QJ7394Bk/b1ep4oOEJgT0FRSl52EesAkDumxZMrwjB/I90/Sr7XRZg2FSEzcygBq/4f tNCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date; bh=GgdJiDF0VLPQbNAyYcFpOP72gRQboKkP7dhdfaG4z0I=; b=vMrhy0gxGF+vBu10a6pVi0u74M6ISN4oKvuTe7sTvY6JxMAUDqO5ggSooEOIBaihnC oxeolcUss2Ct0pXtqLPRxPBIzdgCHeHetEy0l9XhVn8hPEdN9MGmbMs5Y/2KlPuNlCaV fqUHqpW8IOff69XNUIl5micw83iumPJE9YGW+XOVMSFRIXb4m20GXf8glH/iC6gM3mCL dOoZIp1+rfzfbfHdCfsJ3anPcfwKFQct4Ah//Ea25bnyuMCtsE4lmk/28oJNshy1+Ib3 TbKNmUQ28tGHtDWWpUBY6vUkukna/1ZIxsrqT8ivSl8VvtT4qNlW5J29VyjNRFeG3Hr3 yn3g== X-Gm-Message-State: ACrzQf0mKJdHrVZfWnqpVDR5O+ZZZfaJDzVCvDe9Xlcb1Nfrht1ttj+w k/oAztHSQd4/UsJLVJ+Ah6c= X-Google-Smtp-Source: AMsMyM5WQdYeHA0da5sGa9jilnE+S+Z9JTbSKaCUvr7kho56k60bMvwN7+e0/7kicSj3rHZ6fIJNIQ== X-Received: by 2002:a17:90b:2686:b0:203:bf90:f791 with SMTP id pl6-20020a17090b268600b00203bf90f791mr1699811pjb.50.1664427072341; Wed, 28 Sep 2022 21:51:12 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id e1-20020a621e01000000b00537a8d2c2easm3671905pfe.80.2022.09.28.21.51.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 28 Sep 2022 21:51:11 -0700 (PDT) Date: Thu, 29 Sep 2022 13:51:09 +0900 (JST) Message-Id: <20220929.135109.686813839550314879.horikyota.ntt@gmail.com> To: bt22nakamorit@oss.nttdata.com Cc: torikoshia@oss.nttdata.com, pgsql-hackers@lists.postgresql.org Subject: Re: Make ON_ERROR_STOP stop on shell script failure From: Kyotaro Horiguchi In-Reply-To: <20220929.123504.1824301713608286657.horikyota.ntt@gmail.com> References: <6fd74d4bf62664b0320cde3f7a48f522@oss.nttdata.com> <36360350378935c823a9dbbff5b2e54e@oss.nttdata.com> <20220929.123504.1824301713608286657.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Thu, 29 Sep 2022 12:35:04 +0900 (JST), Kyotaro Horiguchi wrote in > > Thank you for the feedback! > > I agree that the messages should be more clear. > > \\!: command was not executed > > \\!: command failed > > Would these two messages be enough to describe the two cases? > > FWIW, I would spell these as something like this: > > > \\!: command execution failure: %m The following might be more complient to our policy. > \\!: failed to execute command \"%s\": %m > > \\!: command returned failure status: %d regards. -- Kyotaro Horiguchi NTT Open Source Software Center