Date: Fri, 30 Sep 2022 13:49:51 +0900 (JST)
Message-Id: <20220930.134951.2176153950673898915.horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: bdrouvot@amazon.com, sawada.mshk@gmail.com,
 ashutosh.bapat.oss@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: more descriptive message for process termination due to
 max_slot_wal_keep_size
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <517851.1664506140@sss.pgh.pa.us>
References: <332715.1664472660@sss.pgh.pa.us>
	<20220930.111519.865126851436936262.horikyota.ntt@gmail.com>
	<517851.1664506140@sss.pgh.pa.us>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20220930.134951.2176153950673898915.horikyota.ntt%40gmail.com>
Precedence: bulk

At Thu, 29 Sep 2022 22:49:00 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in 
> Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> > By the way, I didn't notice at that time (and forgot about the
> > policy), but the HINT message has variations differing only by the
> > variable name.
> 
> > What do you think about the attached?
> 
> Hmm, maybe, but a quick grep for 'You might need to increase'
> finds about a dozen other cases, and none of them are using %s.
(Mmm. I didn't find others only in po files..)
> If we do this we should change all of them, and they probably
> need "translator:" hints.  I'm not sure whether abstracting
> away the variable names will make translation harder.

I expect that dedicated po-editing tools can lookup corresponding code
lines, which gives the answer if no hint is attached at least in this
specific case.

Anyway, thinking calmly, since we are not about to edit these
messages, it's unlikely to happen on purpose, I think. So I don't mean
to push this so hard.

Thanks for the comment!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center