Date: Fri, 30 Sep 2022 12:23:50 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Message-ID: <20220930192350.GA171832@nathanxps13>
References: <20220920035147.GA114383@nathanxps13>
 <YylTkIwvWuYJkMnT@paquier.xyz>
 <20220920180533.GA205278@nathanxps13>
 <20220920233117.GA378596@nathanxps13>
 <20220920235010.GB378596@nathanxps13>
 <Yyppg/c4SB7s1IAv@paquier.xyz>
 <20220921043126.GA382738@nathanxps13>
 <20220928185034.GA1397229@nathanxps13>
 <CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
 <20220928201222.GA1400058@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220928201222.GA1400058@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20220930192350.GA171832%40nathanxps13>
Precedence: bulk

On Wed, Sep 28, 2022 at 01:12:22PM -0700, Nathan Bossart wrote:
> On Wed, Sep 28, 2022 at 03:09:46PM -0400, Stephen Frost wrote:
>> The max is the same regardless of the size..?  Considering the size is
>> capped since pg_class doesn’t (and isn’t likely to..) have a toast table,
>> that seems unlikely, so I’m asking for clarification on that. We may be
>> able to get consensus that the difference isn’t material since no one is
>> likely to have such long lists, but we should at least be aware.
> 
> While pg_class doesn't have a TOAST table, that column is marked as
> "extended," so I believe it is still compressed, and the maximum aclitem
> array length for pg_class.relacl would depend on how well the array
> compresses.

Are there any remaining concerns about this approach?  I'm happy to do any
testing that folks deem necessary, or anything else really that might help
move this patch set forward.  If we don't want to extend AclMode right
away, we could also keep it in our back pocket for the next time someone
(which may very well be me) wants to add privileges.  That is, 0001 is not
fundamentally a prerequisite for 0002-0004, but I recognize that freeing up
some extra bits would be the most courteous.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com