Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of13r-0001sl-2g for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Oct 2022 15:39:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1of13p-0003X0-5V for pgsql-hackers@arkaria.postgresql.org; Sun, 02 Oct 2022 15:39:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of13n-0003Pz-Bp for pgsql-hackers@lists.postgresql.org; Sun, 02 Oct 2022 15:39:20 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of13f-0002Sl-MZ for pgsql-hackers@lists.postgresql.org; Sun, 02 Oct 2022 15:39:18 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 8A4A23200900; Sun, 2 Oct 2022 11:39:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 02 Oct 2022 11:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1664725148; x=1664811548; bh=aQJunresnV rCqTW0tIZL6Z2d8Nst9toXa53i+ag9L00=; b=QqN5G7Ue0uKCIxPUKdE4qVs/xc AAiNARsch3NHiwhQU3XmXBKg6m+4gFpjHafJrdtEC9mBhMPuzbxp9YWtE3MF5LzY pBU6qgCrYibsDPUPuWi1VhDkGgYMj9HcX+WgGECFBJWRD+t/hY4j19ui5hEkUXr5 M0faIm+pjnX0NxPaCmD7XdqNwCB4wCIrmYu1z+TTSXRIC3ZouzGIX+YWylmUMk7D qiYyXAPy1Ba0MJT/P6VNak5W3EyWtbKGcovg+63tac7RqmgtkXlxjAyXANhvjbNN Xym8pUULtdFUe8Nozsi4p1f/75kOnD5gBp8iatOXRMNSBt8SdAudQn3GEc6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664725148; x=1664811548; bh=aQJunresnVrCqTW0tIZL6Z2d8Nst 9toXa53i+ag9L00=; b=AiiRZMbNd2spEFUXg4QAxRLXNgYxl/7FikbXtGnX1DVA hbuqa1N0yS0rA1cVd+KSa2cGuSyrAjCQS8rjyR3z+wtMDsyYzqeyap6pSHrqLPMV mrWdokH/hR8yAvN7YFqcNHTdfq//9H90m7S03Obnsn0fJqXtfRKYAsQKRZdCTxJF /TTnMemKGiwOjUAX4E0oEQ5r8Wi9DxkKfWlugKClb9MxpuUljgIyBUmwLvFVg0ja aq45ND+MD/6TB1TuWKPExXqRT/hCpeCW9MrUqLqNTgWPlO8+Qw32vM3gCNsJe4t3 Yv0Ju4PkguWyTl0lBtNwA1VKJEKYh7NXdtRO3UH4Fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehjedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhephfegjedtudegveffteefjeeljedvgeetueelffdtffejgeffgeeggeff teegheeunecuffhomhgrihhnpegtihhrrhhushdqtghirdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgr iigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Oct 2022 11:39:07 -0400 (EDT) Date: Sun, 2 Oct 2022 08:39:05 -0700 From: Andres Freund To: "kuroda.hayato@fujitsu.com" Cc: 'Fujii Masao' , "pgsql-hackers@lists.postgresql.org" , "Shinya11.Kato@oss.nttdata.com" , "zyu@yugabyte.com" , 'Kyotaro Horiguchi' Subject: Re: [Proposal] Add foreign-server health checks infrastructure Message-ID: <20221002153905.kaadndwwqemd3eu2@awork3.anarazel.de> References: <20220217.170832.627054018291482509.horikyota.ntt@gmail.com> <379473f3-ed14-a19f-92ed-91dc73d430d3@oss.nttdata.com> <4968741d-f32c-a251-efc9-2d3db83e6891@oss.nttdata.com> <2160c6db-079a-be7c-df96-6c5cb21c03cf@oss.nttdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-09-21 11:56:56 +0000, kuroda.hayato@fujitsu.com wrote: > PSA rebased patches. I reviewed my myself and they contain changes. > E.g., move GUC-related code to option.c. This seems to reliably fail on windows. See https://cirrus-ci.com/task/6454408568373248 https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3388 https://api.cirrus-ci.com/v1/artifact/task/6454408568373248/testrun/build/testrun/postgres_fdw/regress/regression.diffs diff -w -U3 C:/cirrus/contrib/postgres_fdw/expected/postgres_fdw.out C:/cirrus/build/testrun/postgres_fdw/regress/results/postgres_fdw.out --- C:/cirrus/contrib/postgres_fdw/expected/postgres_fdw.out 2022-10-02 14:47:24.486355800 +0000 +++ C:/cirrus/build/testrun/postgres_fdw/regress/results/postgres_fdw.out 2022-10-02 15:02:03.039752800 +0000 @@ -11478,6 +11478,8 @@ ALTER SERVER loopback OPTIONS (SET application_name 'healthcheck'); -- Set GUC for checking the health of remote servers SET postgres_fdw.health_check_interval TO '1s'; +ERROR: invalid value for parameter "postgres_fdw.health_check_interval": 1000 +DETAIL: postgres_fdw.health_check_interval must be set to 0 on this platform BEGIN; SELECT 1 FROM ft1 LIMIT 1; ?column? @@ -11495,7 +11497,15 @@ -- While sleeping the process down will be detected. SELECT pg_sleep(3); -ERROR: Foreign Server loopback might be down. + pg_sleep +---------- + +(1 row) + COMMIT; +ERROR: server closed the connection unexpectedly + This probably means the server terminated abnormally + before or while processing the request. +CONTEXT: remote SQL command: COMMIT TRANSACTION -- Clean up RESET debug_discard_caches; Greetings, Andres Freund