Date: Sun, 2 Oct 2022 13:38:37 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Peter Geoghegan <pg@bowt.ie>,
	"wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Thomas Munro <thomas.munro@gmail.com>,
	samay sharma <smilingsamay@gmail.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson - v13
Message-ID: <20221002183837.GD7745@telsasoft.com>
References: <20220922202809.4touie37lfafyabw@awork3.anarazel.de>
 <20220922223729.GA721620@nathanxps13>
 <2298281.1664041949@sss.pgh.pa.us>
 <20220924180955.2hevwoniwsj2q2tm@awork3.anarazel.de>
 <c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com>
 <20220926163516.ftxjmoljjwyy4m2q@awork3.anarazel.de>
 <20220926194435.4hhrwu7d6anrapc3@awork3.anarazel.de>
 <20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de>
 <20221002172520.GC7745@telsasoft.com>
 <20221002180530.fkhl6kpx734dlmow@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221002180530.fkhl6kpx734dlmow@awork3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221002183837.GD7745%40telsasoft.com>
Precedence: bulk

On Sun, Oct 02, 2022 at 11:05:30AM -0700, Andres Freund wrote:
> > Also, you wrote "rm -fr build" between building for gcc and clang, but
> > since they run in an "always" block, it'd be better to use separate
> > dirs, to allow seeing logs for the the all (failed) tasks, in case the
> > last one succeeds.
> 
> Hm, when are logs important for CompilerWarnings? I don't think we even
> collect any?  Using a different builddir for the "sibling" tests (i.e. the two
> gcc and the two clang tests) would increase the times a bit because we'd
> regenerate the bison files etc.
> 
> I guess it'll look a bit cleaner to use a build-gcc and a build-clang, just to
> get rid of the irregularity of needing that rm -rf.

The build logs are important when hacking on .cirrus.yml itself.

You're right that we don't normally save logs for CompilerWarnings; one or
another (unpublished) patch of mine adds that, and then also needed to change
to use separate dirs in order to debug building while experimenting with your
patch to use meson.

-- 
Justin