Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohpB9-0003A2-DQ for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Oct 2022 09:34:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ohpB8-0007WV-1p for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Oct 2022 09:34:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohpB7-0007WM-Ow for pgsql-hackers@lists.postgresql.org; Mon, 10 Oct 2022 09:34:29 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohpB0-00041X-6w for pgsql-hackers@lists.postgresql.org; Mon, 10 Oct 2022 09:34:29 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A14C332008FD for ; Mon, 10 Oct 2022 05:34:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 10 Oct 2022 05:34:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665394458; x=1665480858; bh=P3vOGArPzFhpTqS2kSgRvIbIwDxb 1jotIzLh2Rm/tb8=; b=F1GPPYW48jMG5XlZXfJoGtQL7YUi//oXxxf1vQocGgWg kBN0OeslUWaTfxe/VcYUr0yVSSw6ldRnsecS1ikxLFFdsf3sQI5azg+5R3bp11hW 9tG9mYWYInJEvGuDSwM0XfV3wjcNlqaHlpF/Nz9Pdf1FvnAQsjWDGQjraYv2IDcD ID7iULJ6Y8aN+UlT+zscLX2wEMfw6w0xkCa4ix5BKntRHiduNe/QLPDAB6j6VJk5 BM4tU+DbXTRjJ8K67P1H+X3Q+upv5FKdgBYbnQ9rLFT230pB57XnkUteNFR66YhZ po5J0F8FPdPzxgfg/+X/jPSOks8facOQjKYJ28iHUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejgedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfesmhekreertddtjeenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepkeeklefhtdefhfevhfetieejveffleevudduheefffffveff vddukeeikeefieeinecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgv rhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 10 Oct 2022 05:34:17 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id EF71B66; Mon, 10 Oct 2022 11:34:15 +0200 (CEST) Date: Mon, 10 Oct 2022 11:34:15 +0200 From: Alvaro Herrera To: Pg Hackers Subject: src/test/perl/PostgreSQL/Test/*.pm not installed Message-ID: <20221010093415.poplkyn7pjeiv2y7@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="dtyrjrxbf7tbf2l5" Content-Disposition: inline Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --dtyrjrxbf7tbf2l5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit I noticed that the new Perl test modules are not installed, so if you try to use PostgreSQL/Test/Cluster.pm in an external test from pgxs, it fails with the modules not being found. I see no reason for this other than having overseen it in b235d41d9646, so I propose the attached (for all branches, naturally.) -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "La gente vulgar sólo piensa en pasar el tiempo; el que tiene talento, en aprovecharlo" --dtyrjrxbf7tbf2l5 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="install-perl-test.patch" diff --git a/src/test/perl/Makefile b/src/test/perl/Makefile index 3d3a95b52f..79f790772f 100644 --- a/src/test/perl/Makefile +++ b/src/test/perl/Makefile @@ -17,6 +17,7 @@ ifeq ($(enable_tap_tests),yes) installdirs: $(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)' + $(MKDIR_P) '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test' install: all installdirs $(INSTALL_DATA) $(srcdir)/TestLib.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/TestLib.pm' @@ -24,6 +25,8 @@ install: all installdirs $(INSTALL_DATA) $(srcdir)/RecursiveCopy.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/RecursiveCopy.pm' $(INSTALL_DATA) $(srcdir)/PostgresNode.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresNode.pm' $(INSTALL_DATA) $(srcdir)/PostgresVersion.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresVersion.pm' + $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm' + $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Utils.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Utils.pm' uninstall: rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/TestLib.pm' @@ -31,5 +34,7 @@ uninstall: rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/RecursiveCopy.pm' rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresNode.pm' rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgresVersion.pm' + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm' + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Utils.pm' endif --dtyrjrxbf7tbf2l5--