Feedback-ID: id4a34324:Fastmail
Date: Mon, 10 Oct 2022 09:37:38 -0700
From: Andres Freund <andres@anarazel.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
	Tomas Vondra <tomas.vondra@postgresql.org>,
	Peter Smith <smithpb2250@gmail.com>
Subject: Re: shadow variables - pg15 edition
Message-ID: <20221010163738.iyo7w5cfdy7kyxid@awork3.anarazel.de>
References: <20221010162732.5stcy665zsyxkaq6@awork3.anarazel.de>
 <20221010163311.k3ofugjziqu637ne@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221010163311.k3ofugjziqu637ne@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/20221010163738.iyo7w5cfdy7kyxid%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-10-10 18:33:11 +0200, Alvaro Herrera wrote:
> On 2022-Oct-10, Andres Freund wrote:
> 
> > Given the age of affected perl instances I suspect there'll not be a lot of
> > developers affected, and the number of warnings is reasonably small too. It'd
> > likely hurt more developers to not see the warnings locally, given that such
> > shadowing often causes bugs.
> 
> Maybe we can install a filter-out in src/pl/plperl's Makefile for the
> time being.

We could, but is it really a useful thing for something fixed 6 years ago?

Greetings,

Andres Freund