Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okLQe-0007CQ-VV for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Oct 2022 08:24:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1okLQd-00075c-Ri for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Oct 2022 08:24:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okLQd-00073f-Ho for pgsql-hackers@lists.postgresql.org; Mon, 17 Oct 2022 08:24:55 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okLQa-0006Jd-LX for pgsql-hackers@lists.postgresql.org; Mon, 17 Oct 2022 08:24:54 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CBA2E5C008E for ; Mon, 17 Oct 2022 04:24:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 17 Oct 2022 04:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665995091; x=1666081491; bh=R1fxx9Es7WARd+FX7s0mOu0hSe6X I849EXyKTqDlNP0=; b=lkmDjNjIiPuvpNuquZ0Fshe2eEyY6xRGDnS0J/DltlUg waWo3EC1ZyXpaJG52ZOtwaTM8kavyBTI4Mn5o604eA6KItfCqC7MJCCpdLRaW4Np XyJxZvz2kDCQWfYjFu/3+/5V34rKf1TZTJLoTV4bdh910mliEV/zjPoyGAI7Mm+5 z4Z1UQny79Y4AeBrxXRLxn+qaOGWe9B7zpIGb1S8OVbLpC3fTxujmLoa3KcWQHLZ b7tlgZUGRJ8p+JQFC8/ymrasVrjjL3WAlwzU35UYOr8Su1sqhXwM/lwidjZ67qBk PR3dQiZBJBkji7ySn+un1O96WhAl1cG8IMF+N0BBLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeekledgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfesmhekreertddtjeenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepkeeklefhtdefhfevhfetieejveffleevudduheefffffveff vddukeeikeefieeinecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgv rhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 17 Oct 2022 04:24:51 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 8CD736D; Mon, 17 Oct 2022 10:16:49 +0200 (CEST) Date: Mon, 17 Oct 2022 10:16:49 +0200 From: Alvaro Herrera To: Pg Hackers Subject: remove no longer necessary Perl compatibility hack Message-ID: <20221017081649.fjcd2kjqif77uyf2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="34uc6fqarit4f6bq" Content-Disposition: inline Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --34uc6fqarit4f6bq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hello While messing about with Cluster.pm I noticed that we don't need the hack to work around lack of parent.pm in very old Perl versions, because we no longer support those versions (per commit 4c1532763a00). Trivial patch attached. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "El que vive para el futuro es un iluso, y el que vive para el pasado, un imbécil" (Luis Adler, "Los tripulantes de la noche") --34uc6fqarit4f6bq Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Remove-no-longer-needed-compatibility-hack.patch" From f85b0302b343e7867274e05ec982ce3c1432eb59 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Mon, 17 Oct 2022 10:11:05 +0200 Subject: [PATCH] Remove no-longer-needed compatibility hack Our Perl version requirement was raised to 5.14 by commit 4c1532763a00 --- src/test/perl/PostgreSQL/Test/Cluster.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm index 4a64cb749b..2a8131df4a 100644 --- a/src/test/perl/PostgreSQL/Test/Cluster.pm +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm @@ -2940,10 +2940,7 @@ $SIG{TERM} = $SIG{INT} = sub package PostgreSQL::Test::Cluster::V_11 ; ## no critic (ProhibitMultiplePackages) -# parent.pm is not present in all perl versions before 5.10.1, so instead -# do directly what it would do for this: -# use parent -norequire, qw(PostgreSQL::Test::Cluster); -push @PostgreSQL::Test::Cluster::V_11::ISA, 'PostgreSQL::Test::Cluster'; +use parent -norequire, qw(PostgreSQL::Test::Cluster); # https://www.postgresql.org/docs/11/release-11.html @@ -2971,8 +2968,7 @@ sub init package PostgreSQL::Test::Cluster::V_10 ; ## no critic (ProhibitMultiplePackages) -# use parent -norequire, qw(PostgreSQL::Test::Cluster::V_11); -push @PostgreSQL::Test::Cluster::V_10::ISA, 'PostgreSQL::Test::Cluster::V_11'; +use parent -norequire, qw(PostgreSQL::Test::Cluster::V_11); # https://www.postgresql.org/docs/10/release-10.html -- 2.30.2 --34uc6fqarit4f6bq--