public inbox for [email protected]
help / color / mirror / Atom feedFrom: Justin Pryzby <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: Peter Smith <[email protected]>
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Date: Mon, 24 Oct 2022 17:05:44 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On Mon, Sep 26, 2022 at 05:29:58PM +0900, Kyotaro Horiguchi wrote:
> At Sat, 17 Sep 2022 23:53:07 -0500, Justin Pryzby <[email protected]> wrote in
> > This is an alternative implementation, which still relies on adding the
> > GUC_DYNAMIC, flag but doesn't require adding a new, sql-accessible
> > function to convert the GUC to a pretty/human display value.
>
> Thanks!
>
> I'm not sure shared_buffer is GUC_DYNAMIC_DEFAULT, and we need to read
It's set during initdb.
> postgresql.conf.sample using SQL, but +1 for the direction.
>
> + AND NOT (sc.sample_value ~ '^0' AND current_setting(name) ~ '^0') -- zeros may be written differently
> + AND NOT (sc.sample_value='60s' AND current_setting(name) = '1min') -- two ways to write 1min
>
> Mmm. Couldn't we get away from that explicit exceptions?
Suggestions are welcomed.
Rebased the patch.
I also split the flag into DEFAULTS_COMPILE and DEFAULTS_INITDB, since
that makes it easier to understand what the flags mean and the intent of
the patch. And maybe allows fewer exclusions in patches like Peter's,
which I think would only want to exclude compile-time defaults.
--
Justin
view thread (42+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox