Date: Thu, 27 Oct 2022 19:38:15 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>, Tom Lane <tgl@sss.pgh.pa.us>,
	Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org, "Bossart, Nathan" <bossartn@amazon.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	David Steele <david@pgmasters.net>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
Message-ID: <20221028003815.GG16921@telsasoft.com>
References: <20220125192755.GK23027@telsasoft.com>
 <20220624043549.GC22452@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Pk/CTwBz1VvfPIDp"
Content-Disposition: inline
In-Reply-To: <20220624043549.GC22452@telsasoft.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221028003815.GG16921%40telsasoft.com>
Precedence: bulk


--Pk/CTwBz1VvfPIDp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 13, 2019 at 03:03:47PM +1300, Thomas Munro wrote:
> > Actually, I tried using pg_ls_tmpdir(), but it unconditionally masks
> > non-regular files and thus shared filesets.  Maybe that's worth
> > discussion on a new thread ?
> >
> > src/backend/utils/adt/genfile.c
> >                 /* Ignore anything but regular files */
> >                 if (!S_ISREG(attrib.st_mode))
> >                         continue;
> 
> +1, that's worth fixing.

@cfbot: rebased on eddc128be.

--Pk/CTwBz1VvfPIDp
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v37-0001-Document-historic-behavior-of-links-to-directori.patch"