Date: Sat, 29 Oct 2022 12:40:53 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Maciek Sakrejda <m.sakrejda@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Cary Huang <cary.huang@highgo.ca>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: warn if GUC set to an invalid shared library
Message-ID: <20221029174053.GA19704@telsasoft.com>
References: <20220210015854.GV31460@telsasoft.com>
 <CAOtHd0CQxJCAF77T+0buj57p5EycwzELfyAWMhJ8oZ3nzCZ6fw@mail.gmail.com>
 <20220722015412.GA7789@telsasoft.com>
 <CAOtHd0Ca3o_YX-2xC+0SOJD242QDHKCS16bG2AX9QQkKsdBF7Q@mail.gmail.com>
 <675610.1658512401@sss.pgh.pa.us>
 <20220722183557.GC7789@telsasoft.com>
 <729940.1658516423@sss.pgh.pa.us>
 <20220722191443.GE7789@telsasoft.com>
 <734432.1658518007@sss.pgh.pa.us>
 <20220902222458.GC31833@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220902222458.GC31833@telsasoft.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221029174053.GA19704%40telsasoft.com>
Precedence: bulk

On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote:
> It caused no issue when I changed:
> 
>                         /* Check that it's acceptable for the indicated parameter */
>                         if (!parse_and_validate_value(record, name, value,
> -                                                     PGC_S_FILE, ERROR,
> +                                                     PGC_S_TEST, ERROR,
>                                                       &newval, &newextra))
> 
> I'm not sure where to go from here.

I'm hoping for some guidance ; this simple change may be naive, but I'm not
sure what a wider change would look like.

-- 
Justin