Feedback-ID: ia2694551:Fastmail
Date: Sun, 30 Oct 2022 16:52:39 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: ilya.v.gladyshev@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Segfault on logical replication to partitioned table with
 foreign children
Message-ID: <20221030155239.55zehfskzdppokox@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6b93e3748ba43298694f376ca8797279d7945e29.camel@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20221030155239.55zehfskzdppokox%40alvherre.pgsql>
Precedence: bulk

On 2022-Oct-28, ilya.v.gladyshev@gmail.com wrote:

> This will cause a segfault or raise an assert, because inserting into
> foreign tables via logical replication is not possible. The solution I
> propose is to add recursive checks of relkind for children of a target,
> if the target is a partitioned table.

However, I imagine that the only reason we don't support this is that
the code hasn't been written yet. I think it would be better to write
that code, so that we don't have to raise any error at all (unless the
foreign table is something that doesn't support DML, in which case we
would have to raise an error).  Of course, we still have to fix it in
backbranches, but we can just do it as a targeted check at the moment of
insert/update, not at the moment of subscription create/alter.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"The eagle never lost so much time, as
when he submitted to learn of the crow." (William Blake)