Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opdPo-0006Da-LJ for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Oct 2022 22:37:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1opdPn-00037f-I0 for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Oct 2022 22:37:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opdPn-00037S-2o for pgsql-hackers@lists.postgresql.org; Mon, 31 Oct 2022 22:37:55 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1opdPg-0005Vf-FX for pgsql-hackers@postgresql.org; Mon, 31 Oct 2022 22:37:54 +0000 Received: by mail-io1-xd2a.google.com with SMTP id h206so7525198iof.10 for ; Mon, 31 Oct 2022 15:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3xWp9y0OPGaNxYCtlVmRNqKDrBenfwUNehjA4gI8Q9k=; b=J0VpfldSF4Y0XTTgO0MolheqIJVDheq2z4pVSRxNbSZkOrY2x/vUi55nDcRZTY103P D9MgjgtuVNyOriZNgTBiMW913/LQKmdLyT93xlz2f9D79doXEI0O5/pklWD+jTV5/73l gWwKhayl9x6L3JIJf8KO1IEbwQ2wXEMmDZbBG+ybCSaLV0NvkQwsNwoU/vtEpbnOJVLq mcRmZhgstu5NXEYY/vKC3dJ3jPi2xWONndek77Am1XWTxu5LVsAYYX4gPWI4Bbpf9qiV eXgH1E2wiTsefLbgTNKhu2/ezLLADjABrZeJiXnYylS56Ng0bE3Gp1DAEsWQ2K8y6MDE wn+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3xWp9y0OPGaNxYCtlVmRNqKDrBenfwUNehjA4gI8Q9k=; b=Vmh+1p2UtFoMOtoShM4fZPTqOfC43W8zd3m7HT4kgGW6It5CfZ0OpQFRhh5B1AOl9t Y0XemDc6S8Z4/KSv41O7qhn43XgyNyiMQoWRsXE2eYP/kHJDvRR/rO4jRSCttNEmm5CX o0qYFDhZc1nbtr/QaaBY8h7Gaf8Wmgw0m6i+7fI5wHAH9k3r09WfOCWqs1Eob0C/EQhw z043EZnLe0Kj9Q3cjndocuhILUF6rSXaSfioerM4m8AKIYVKv1oHMblXw2yV2SDymZQ6 Kkz/jKkqYBzpNgw1oUU2ScFy4WDh/PP6wGUyRhECXTPBqVDoArtjV5Hz8W6FlNXjPfFf 03tg== X-Gm-Message-State: ACrzQf0UGU9RLnAoKStuR2WmKExlabxXazZEYf8Kl3FX4MWQHdcls84B OlagRj8JLVjtU7FF41vTKmYokw== X-Google-Smtp-Source: AMsMyM5/s5f35fOkh9t8kSvt3v36f1wtlDSyfAJS8Xk31u3zSGBquIUv5hD1W0118foRm6+ojov+Nw== X-Received: by 2002:a05:6638:26b:b0:375:6c86:5761 with SMTP id x11-20020a056638026b00b003756c865761mr1211162jaq.313.1667255866371; Mon, 31 Oct 2022 15:37:46 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id x13-20020a026f0d000000b00365c378e991sm3237536jab.124.2022.10.31.15.37.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2022 15:37:45 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id E0C558009D6; Mon, 31 Oct 2022 17:37:44 -0500 (CDT) Date: Mon, 31 Oct 2022 17:37:44 -0500 From: Justin Pryzby To: Melanie Plageman Cc: pgsql-hackers@postgresql.org, Andres Freund Subject: Re: heapgettup refactoring Message-ID: <20221031223744.GT16921@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk FYI: [18:51:54.707] ../src/backend/access/heap/heapam.c(720): warning C4098: 'heapgettup': 'void' function returning a value [18:51:54.707] ../src/backend/access/heap/heapam.c(850): warning C4098: 'heapgettup_pagemode': 'void' function returning a value For some reason, MSVC is the only one to complain, and cfbot doesn't currently tell you about it. I have a patch to show that, which I'll send $later.