Feedback-ID: id4a34324:Fastmail
Date: Wed, 2 Nov 2022 17:03:34 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>,
	Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement
 -Wshadow=compatible-local
Message-ID: <20221103000334.sbh5jqw37i3y7pc3@awork3.anarazel.de>
References: <20221101180158.l4zg6ljah5ow2vvo@awork3.anarazel.de>
 <e5e13d55-8c8b-30a6-0b13-0304a3e562dd@enterprisedb.com>
 <20221102234346.zcupk5mqysavci4t@awork3.anarazel.de>
 <1881935.1667433465@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1881935.1667433465@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20221103000334.sbh5jqw37i3y7pc3%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-11-02 19:57:45 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2022-11-01 17:00:27 -0400, Peter Eisentraut wrote:
> >> Python has the same issues.  There are a few other Python-embedding projects
> >> that use -Wdeclaration-after-statement and complain if the Python headers
> >> violate it.  But it's getting tedious.  -isystem would be a better solution.
> 
> > Which dependencies should we convert to -isystem?
> 
> Color me confused about what's being discussed here.  I see nothing
> in the gcc manual suggesting that -isystem has any effect on warning
> levels?

It's only indirectly explained :(

           The -isystem and -idirafter options also mark the directory as a system directory, so that it gets the same special treatment that is applied to
           the standard system directories.

and then https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html

Greetings,

Andres Freund