Date: Thu, 3 Nov 2022 13:11:18 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Fix proposal for comparaison bugs in PostgreSQL::Version
Message-ID: <20221103181118.GX16921@telsasoft.com>
References: <20220628225325.53d97b8d@karst>
 <ea18cfc3-7f8e-8975-b095-226b1865e2e7@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea18cfc3-7f8e-8975-b095-226b1865e2e7@dunslane.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221103181118.GX16921%40telsasoft.com>
Precedence: bulk

On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote:
> Nice catch, but this looks like massive overkill. I think we can very
> simply fix the test in just a few lines of code, instead of a 190 line
> fix and a 130 line TAP test.
> 
> It was never intended to be able to compare markers like rc1 vs rc2, and
> I don't see any need for it. If you can show me a sane use case I'll
> have another look, but right now it seems quite unnecessary.
> 
> Here's my proposed fix.
> 
> diff --git a/src/test/perl/PostgreSQL/Version.pm b/src/test/perl/PostgreSQL/Version.pm
> index 8f70491189..8d4dbbf694 100644
> --- a/src/test/perl/PostgreSQL/Version.pm

Is this still an outstanding issue ?

-- 
Justin