Date: Fri, 4 Nov 2022 07:19:27 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Daniel Gustafsson <daniel@yesql.se>,
	Andrew Dunstan <andrew@dunslane.net>,
	John Naylor <john.naylor@enterprisedb.com>,
	Erik Rijkers <er@xs4all.nl>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Dean Rasheed <dean.a.rasheed@gmail.com>,
	Stephen Frost <sfrost@snowman.net>,
	Surafel Temesgen <surafel3000@gmail.com>,
	vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: proposal: possibility to read dumped table's name from file
Message-ID: <20221104121927.GZ16921@telsasoft.com>
References: <098531E1-FBA9-4B7D-884E-0A4363EEE6DF@yesql.se>
 <CAFj8pRBuAVoLRrK7ufMO=2oo4ADEM1bprYupafQRDpDGeNGO2A@mail.gmail.com>
 <20221003043435.vlsjtamcfnb2gu3q@jrouhaud>
 <CAFj8pRDdK9vBcpqt_4UvtqWtWCZYwYoP3yyVW+mmwhzyNGh3-A@mail.gmail.com>
 <20221013184634.on54trx7mlzpirsj@awork3.anarazel.de>
 <20221018093329.l7qlmxeshw7sssgm@jrouhaud>
 <CAFj8pRCGX_9YtMDXwaVXA6qKBJVziyHj662jmRuei1CPvy=Sqw@mail.gmail.com>
 <20221103040936.3otdcg53pabro3cu@jrouhaud>
 <CAFj8pRAyyXBFiD9U6Gpo7M++Jq33B_L1gWJEnGJu=WcMk+McQA@mail.gmail.com>
 <20221104115901.ik2nxbjtxxhbwksk@jrouhaud>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221104115901.ik2nxbjtxxhbwksk@jrouhaud>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221104121927.GZ16921%40telsasoft.com>
Precedence: bulk

On Fri, Nov 04, 2022 at 07:59:01PM +0800, Julien Rouhaud wrote:
> On Thu, Nov 03, 2022 at 10:22:15PM +0100, Pavel Stehule wrote:
> > čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud <rjuju123@gmail.com> napsal:
> > updated patch attached
> >
> > big thanks for these comments and tips
> 
> Thanks for the updated patch!  As far as I'm concerned the patch is in a good
> shape, passes the CI and I don't have anything more to say so I'm marking it as
> Ready for Committer!

+1

I started looking to see if it's possible to simplify the patch at all,
but nothing to show yet.

But one thing I noticed is that "optarg" looks wrong here:

simple_string_list_append(&opts->triggerNames, optarg);

-- 
Justin