public inbox for [email protected]
help / color / mirror / Atom feedFrom: Julien Rouhaud <[email protected]>
To: Justin Pryzby <[email protected]>
Cc: Pavel Stehule <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: John Naylor <[email protected]>
Cc: Erik Rijkers <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Dean Rasheed <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Surafel Temesgen <[email protected]>
Cc: vignesh C <[email protected]>
Cc: [email protected]
Subject: Re: proposal: possibility to read dumped table's name from file
Date: Fri, 4 Nov 2022 21:28:30 +0800
Message-ID: <20221104132830.yee7hyv6kzaz6kvv@jrouhaud> (raw)
In-Reply-To: <[email protected]>
References: <CAFj8pRBuAVoLRrK7ufMO=2oo4ADEM1bprYupafQRDpDGeNGO2A@mail.gmail.com>
<20221003043435.vlsjtamcfnb2gu3q@jrouhaud>
<CAFj8pRDdK9vBcpqt_4UvtqWtWCZYwYoP3yyVW+mmwhzyNGh3-A@mail.gmail.com>
<[email protected]>
<20221018093329.l7qlmxeshw7sssgm@jrouhaud>
<CAFj8pRCGX_9YtMDXwaVXA6qKBJVziyHj662jmRuei1CPvy=Sqw@mail.gmail.com>
<20221103040936.3otdcg53pabro3cu@jrouhaud>
<CAFj8pRAyyXBFiD9U6Gpo7M++Jq33B_L1gWJEnGJu=WcMk+McQA@mail.gmail.com>
<20221104115901.ik2nxbjtxxhbwksk@jrouhaud>
<[email protected]>
On Fri, Nov 04, 2022 at 07:19:27AM -0500, Justin Pryzby wrote:
> On Fri, Nov 04, 2022 at 07:59:01PM +0800, Julien Rouhaud wrote:
> > On Thu, Nov 03, 2022 at 10:22:15PM +0100, Pavel Stehule wrote:
> > > čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud <[email protected]> napsal:
> > > updated patch attached
> > >
> > > big thanks for these comments and tips
> >
> > Thanks for the updated patch! As far as I'm concerned the patch is in a good
> > shape, passes the CI and I don't have anything more to say so I'm marking it as
> > Ready for Committer!
>
> +1
>
> I started looking to see if it's possible to simplify the patch at all,
> but nothing to show yet.
>
> But one thing I noticed is that "optarg" looks wrong here:
>
> simple_string_list_append(&opts->triggerNames, optarg);
Ah indeed, good catch! Maybe there should be an explicit test for every
(include|exclude) / objtype combination? It would be a bit verbose (and
possibly hard to maintain).
view thread (181+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: proposal: possibility to read dumped table's name from file
In-Reply-To: <20221104132830.yee7hyv6kzaz6kvv@jrouhaud>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox