Date: Tue, 8 Nov 2022 16:45:19 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: David Christensen <david.christensen@crunchydata.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Message-ID: <20221108224519.GH3775@telsasoft.com>
References: <20221104140238.GA16921@telsasoft.com>
 <4E379ADE-1FC3-4D53-BE46-562BDC77C5FE@crunchydata.com>
 <20221104183838.GD16921@telsasoft.com>
 <CAOxo6X+2-k6gqwv2okbgLR_B_MkBCVHOW3CqFomFta2wNkHYdw@mail.gmail.com>
 <CAOxo6XJt=F3eKS8-jvFYoW2MVP+DCpseHPHYiLVYGF43iET30Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="phCU5ROyZO6kBE05"
Content-Disposition: inline
In-Reply-To: 
 <CAOxo6XJt=F3eKS8-jvFYoW2MVP+DCpseHPHYiLVYGF43iET30Q@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221108224519.GH3775%40telsasoft.com>
Precedence: bulk


--phCU5ROyZO6kBE05
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 07, 2022 at 05:01:01PM -0600, David Christensen wrote:
> Hi Justin et al,
> 
> Enclosed is v5 of this patch which now passes the CirrusCI checks for
> all supported OSes. I went ahead and reworked the test a bit so it's a
> little more amenable to the OS-agnostic approach for testing.

Great, thanks.

This includes the changes that I'd started a few months ago.
Plus adding the test which was missing for meson.

+        format: <literal><replaceable>LSN</replaceable>.<replaceable>TSOID</replaceable>.<replaceable>DBOID</replaceable>.<replaceable>RELNODE</replaceable>.<replaceable>BLKNO</replaceable></literal>

I'd prefer if the abbreviations were "reltablespace" and "datoid"

Also, should the test case call pg_relation_filenode() rather than using
relfilenode directly ?  Is it a problem that the test code assumes
pagesize=8192 ?

-- 
Justin

--phCU5ROyZO6kBE05
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-Teach-pg_waldump-to-extract-FPIs-from-the-WAL-stream.patch"