Feedback-ID: ia2694551:Fastmail
Date: Wed, 9 Nov 2022 15:32:07 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	David Christensen <david.christensen@crunchydata.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Message-ID: <20221109143207.me7xnbak72ri365e@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221109141446.GN3775@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20221109143207.me7xnbak72ri365e%40alvherre.pgsql>
Precedence: bulk

On 2022-Nov-09, Justin Pryzby wrote:

> On Wed, Nov 09, 2022 at 06:00:40PM +0530, Bharath Rupireddy wrote:

> > 1. For ease of review, please split the test patch to 0002.
> 
> This is just my opinion, but .. why ?  Since it's easy to
> filter/skip/display a file, I don't think it's usually useful to have
> separate patches for tests or docs.

I concur with Justin.  When a patch is bugfix and a test is added that
verifies it, I like to keep the test in a separate commit (for submit
purposes and in my personal repo -- not for the official push!) so that
I can git-checkout to just the test and make sure it fails ahead of
pushing the fix commit.  But for a new feature, there's no reason to do
so.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/