Date: Fri, 11 Nov 2022 08:15:04 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: David Christensen <david.christensen@crunchydata.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Message-ID: <20221111141504.GF16809@telsasoft.com>
References: <20221104183838.GD16921@telsasoft.com>
 <CAOxo6X+2-k6gqwv2okbgLR_B_MkBCVHOW3CqFomFta2wNkHYdw@mail.gmail.com>
 <CAOxo6XJt=F3eKS8-jvFYoW2MVP+DCpseHPHYiLVYGF43iET30Q@mail.gmail.com>
 <20221108224519.GH3775@telsasoft.com>
 <CAOxo6XJ_pf+cKDXZMvxprvA1x-Pi+-22fq0Tw50o9HgkXg7cTw@mail.gmail.com>
 <CAOxo6XLCwGGjLEK9--VK9SzOb4EFKiJuSrnOePSPfEyr-pLKPw@mail.gmail.com>
 <CALj2ACWU7ckJLu=9Ag0AahnWT=1E22FsPu9wmcyAEJCv04BCvA@mail.gmail.com>
 <20221109141446.GN3775@telsasoft.com>
 <CAOxo6X+_bSFwsCwMOdxcUV9Hf-FMtHt9fgTLYsbJQgFrXXpqNA@mail.gmail.com>
 <CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221111141504.GF16809%40telsasoft.com>
Precedence: bulk

On Wed, Nov 09, 2022 at 02:37:29PM -0600, David Christensen wrote:
> On Wed, Nov 9, 2022 at 2:08 PM David Christensen <david.christensen@crunchydata.com> wrote:
> > Justin sez:
> > > I was wondering if there's any reason to do "CREATE DATABASE".  The vast
> > > majority of TAP tests don't.
> > >
> > > $ git grep -ho 'safe_psql[^ ]*' '*pl' |sort |uniq -c |sort -nr |head
> > >    1435 safe_psql('postgres',
> > >     335 safe_psql(
> > >      23 safe_psql($connect_db,
> >
> > If there was a reason, I don't recall offhand; I will test removing it
> > and if things still work will consider it good enough.
> 
> Things blew up when I did that; rather than hunt it down, I just left it in. :-)

> +$primary->safe_psql('db1',      <<EOF);

It worked for me when I removed the 3 references to db1.
That's good for efficiency of the test.

> +my $blocksize = 8192;

I think this should be just "my $blocksize;" rather than setting a value
which is later overwriten.

-- 
Justin