Date: Thu, 17 Nov 2022 00:09:33 +0100
From: 'Sandro Santilli' <strk@kbt.io>
Sender: strk@kbt.io
To: Regina Obe <lr@pcorp.us>
Cc: 'Christoph Berg' <cb@df7cb.de>, pgsql-hackers@lists.postgresql.org,
	pgsql-hackers@postgresql.org,
	'Laurenz Albe' <laurenz.albe@cybertec.at>,
	'Tom Lane' <tgl@sss.pgh.pa.us>,
	'Paul Ramsey' <pramsey@cleverelephant.ca>
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Message-ID: <20221116230933.6ynksku66i436ozm@c19>
Mail-Followup-To: 'Sandro Santilli' <strk@kbt.io>, Regina Obe <lr@pcorp.us>,
	'Christoph Berg' <cb@df7cb.de>, pgsql-hackers@lists.postgresql.org,
	pgsql-hackers@postgresql.org,
	'Laurenz Albe' <laurenz.albe@cybertec.at>,
	'Tom Lane' <tgl@sss.pgh.pa.us>,
	'Paul Ramsey' <pramsey@cleverelephant.ca>
References: <YgakFklJyM5pNdt+@c19>
 <001d01d87211$edbd5b50$c93811f0$@pcorp.us>
 <d3924670ba8fefa42f4bd462c5b7f6349d63f4d3.camel@cybertec.at>
 <Ypsj95RJSARwfQt6@c19>
 <YyJPHOfwLIjxxi9u@c19>
 <Y25zMZG45ENExfNL@msg.df7cb.de>
 <000001d8f7e4$1c840d50$558c27f0$@pcorp.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="pikujl27r76rlaub"
Content-Disposition: inline
In-Reply-To: <000001d8f7e4$1c840d50$558c27f0$@pcorp.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20221116230933.6ynksku66i436ozm%40c19>
Precedence: bulk


--pikujl27r76rlaub
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Nov 13, 2022 at 11:46:50PM -0500, Regina Obe wrote:
> > Re: Sandro Santilli
> > > I'm attaching an updated version of the patch. This time the patch is
> > > tested. Nothing changes unless the .control file for the subject
> > > extension doesn't have a "wildcard_upgrades = true" statement.
> > >
> > > When wildcard upgrades are enabled, a file with a "%" symbol as the
> > > "source" part of the upgrade path will match any version and
> > 
> > Fwiw I believe wildcard_upgrades isn't necessary in the .control file.
> > If there are no % files, none would be used anyway, and if there are, it's
> clear
> > it's meant as wildcard since % won't appear in any remotely sane version
> > number.
> 
> I also like the idea of skipping the wildcard_upgrades syntax.
> Then there is no need to have a conditional control file for PG 16 vs. older
> versions.

Here we go. Attached a version of the patch with no
"wildcard_upgrades" controlling it.

--strk;

--pikujl27r76rlaub
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Allow-wildcard-in-extension-upgrade-paths.patch"