Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxJMv-0005r3-6z for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Nov 2022 02:50:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oxJMu-0007Ws-2y for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Nov 2022 02:50:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxJMt-0007Wj-Oa for pgsql-hackers@lists.postgresql.org; Tue, 22 Nov 2022 02:50:39 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxJMr-0003Sm-E9 for pgsql-hackers@postgresql.org; Tue, 22 Nov 2022 02:50:38 +0000 Received: by mail-pg1-x536.google.com with SMTP id 62so12847785pgb.13 for ; Mon, 21 Nov 2022 18:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wx9x28JhcnoPmTsVQIp1a0vhlS+hylO0GJ2NfKWu4Qs=; b=N74aA4QDTk9y+7szrx6cz+kH4BW58ZKR8oo5ymGrrg298Usz6h11saSeh1tmVsZjDM 7yggJypo5sP87CTPSQlj19jU4CC0I/IaAenNqudhAu8nbmHKGpmtC6uZLUx/0ppGToKC Awu/2Vyb+T+ZgzhVq4IHfsoU7nmliEcruhkG3CKR0a6QuT8hngQlVbzMAaapxsBVYVkb imiV1iKO60kIikKtDTrFi+UfsfQx3LzkALQSWiNRQG5EcIi+aTP+hrsyOhU59WJBneQQ qmMzcad1bNjc91QYCjNoO9HsPDKgMplUOwcKs0+6+rK7QU8rawqPrFCC2MKxC7u1pGHj 3RVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wx9x28JhcnoPmTsVQIp1a0vhlS+hylO0GJ2NfKWu4Qs=; b=Qh14lBpRiLiJBGoBEROLbAwdrQac5Ib8U6JN6RdqdG1NOeQHs+FRRykXwLB5CPKkFz B8Km+gaE6HxGADv9VrGG/dhz8tLIeozynZkvrNnMAwrGf3fS1EIvFsNYP5isBt//BEx7 wYJg6EEYGgKsLMGvb/T8W+ZiDEmM2/u5XPK9mQVi89HW7D1mvMjjFkamGaQ0DuvcwvK9 XnpmW7nM92LYI5azZ5j+/lSub/+0rVEtdkANwoyFW2PDoVtu10b1xFTMKKT1gpot4A91 9nfzeEuNTv8eZn2uqHIu9JJiP5sHDt6l4B/+pujT150nCEWEk3tJwg9T1Qk2nEQ2wnO6 51qg== X-Gm-Message-State: ANoB5pmqwP5bM6dTejxNjcdg63mRaWUQAwNx7IKLPU2p9h6R/tEcREvr 81fIVZXY1QbvQnaho5PlJfQ= X-Google-Smtp-Source: AA0mqf4iCTFiJnW8KU/Zq2qiFypQql6Z/ryfm02liSYmTzN+w+zmjOptWBvO18KgXRNWpc2+5Mktjg== X-Received: by 2002:a62:b417:0:b0:56b:b838:a4de with SMTP id h23-20020a62b417000000b0056bb838a4demr23369860pfn.73.1669085436352; Mon, 21 Nov 2022 18:50:36 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id d125-20020a623683000000b0056da8c41bbasm9333183pfa.161.2022.11.21.18.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 18:50:35 -0800 (PST) Date: Mon, 21 Nov 2022 18:50:33 -0800 From: Nathan Bossart To: Thomas Munro Cc: pgsql-hackers@postgresql.org Subject: Re: wake up logical workers after ALTER SUBSCRIPTION Message-ID: <20221122025033.GA135551@nathanxps13> References: <20221122004119.GA132961@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Nov 22, 2022 at 03:16:05PM +1300, Thomas Munro wrote: > Maybe a comment to explain why a single variable is enough? This crossed my mind shortly after sending my previous message. Looking closer, I see that several types of ALTER SUBSCRIPTION do not call PreventInTransactionBlock(), so a single variable might not be enough. Perhaps we can put a list in TopTransactionContext. I'll do some more investigation and report back. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com