Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxbO8-0007Pr-Om for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Nov 2022 22:05:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oxbO7-0007fz-KB for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Nov 2022 22:05:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxbO7-0007fH-4h for pgsql-hackers@lists.postgresql.org; Tue, 22 Nov 2022 22:05:07 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oxbO0-00077j-C0 for pgsql-hackers@lists.postgresql.org; Tue, 22 Nov 2022 22:05:06 +0000 Received: by mail-qv1-xf35.google.com with SMTP id q10so128331qvt.10 for ; Tue, 22 Nov 2022 14:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=p3MOvseU5VHDDzxA8IUqfZwnCdSwOHSkYFZqU2wCzsE=; b=Yjyk6mMopel94Mppfy5WB2E+PbbB3wnF/E8SOewTBM7amJF6+HBDd5ISpKjr7Umv0A wkkEfIQeL3fLpMtcG4DhjLOW1un3XaG7anZpbq32x5UpvSIIJwxmLVdoUGqvC9JHr54j ITw5/rZoc2oE0odLYvLT0F1/Y2DOgSfd9LqqR3v1xj+3qIiq5RRicmaI7tOYOuSeD5m1 IF1wW9O0UX23tmyNh11k1xnGN19XYqIdJY/ngYH5BDATlPgUs8CcJ+nfJ7MZuJUvKv+x yoacwH/3vQqycB15FvVOx+e5Kau/3dDl7AtQEUDtXyGAbcm6bzF2sdRb97AQ1kHhFFqq h8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p3MOvseU5VHDDzxA8IUqfZwnCdSwOHSkYFZqU2wCzsE=; b=SW740FrThkCabmuY+XwHhYU/oGsey2BQ8wzRFxhYMzVdEwSdrdLvMkM/REtWWEQuJc cXaPn+nU4QP79jDhz2Crp1lH6Z71W8n8eXkCXNBB6oze5NYZ05PvUAwDD38uTMVDXa8z +VrrQKWJegXPEVWsDL7k9BsCGI7XFGAlba3jN/npHAwEU+DSJIaWOYmDL1r8iLaxZPvc lhfzSprU5HcQZdMhBUj2VgpbnqGPTsKYsm/0ITtjTqU4A3iXQOh1JWikbpWGX9dNegmB FLt/5FeG2m6EUcGPcEM4wJnfMN6RBQp3wRf0QJb+F661sJ/zoX8S+9D1sIzC0frcSzmH iDMQ== X-Gm-Message-State: ANoB5pk62p3yV96ixwDmoiBxoQDj9TqDugk6v3r12nqhtSmCmYDBqb4p TrHDt2j6wHycu3mqXyYSFY2LgQ== X-Google-Smtp-Source: AA0mqf5fuBOaMZHqGZAxGZ7F5JUobwKNorXCf7vq0RfRXz5Tqh0FLYLK0n6l5Dss/ewdl+uOpJrxXA== X-Received: by 2002:a05:6214:3241:b0:4bb:6c4c:6beb with SMTP id mt1-20020a056214324100b004bb6c4c6bebmr9491729qvb.40.1669154698498; Tue, 22 Nov 2022 14:04:58 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id q7-20020a05620a0d8700b006f8665f483fsm11135052qkl.85.2022.11.22.14.04.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 14:04:57 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id CA04180080A; Tue, 22 Nov 2022 16:04:56 -0600 (CST) Date: Tue, 22 Nov 2022 16:04:56 -0600 From: Justin Pryzby To: Kyotaro Horiguchi Cc: jchampion@timescale.com, andres@anarazel.de, ashu.coek88@gmail.com, pashkin.elfe@gmail.com, michael@paquier.xyz, bossartn@amazon.com, david@pgmasters.net, peter.eisentraut@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, jtc331@gmail.com, robertmhaas@gmail.com Subject: Re: Make mesage at end-of-recovery less scary. Message-ID: <20221122220456.GE11463@telsasoft.com> References: <20220917042150.GS31833@telsasoft.com> <20220926.161737.1260903443656462873.horikyota.ntt@gmail.com> <20221028023705.GH16921@telsasoft.com> <20221118.172537.1914590795663055479.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="aYDVKSzuImP48n7V" Content-Disposition: inline In-Reply-To: <20221118.172537.1914590795663055479.horikyota.ntt@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --aYDVKSzuImP48n7V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 18, 2022 at 05:25:37PM +0900, Kyotaro Horiguchi wrote: > + while (*p == 0 && p < pe) > + p++; The bug reported by Andres/cfbot/ubsan is here. Fixed in attached. I didn't try to patch the test case to output the failing stderr, but that might be good. --aYDVKSzuImP48n7V Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Make-End-Of-Recovery-error-less-scary.patch"