Feedback-ID: id4a34324:Fastmail
Date: Mon, 28 Nov 2022 10:31:29 -0800
From: Andres Freund <andres@anarazel.de>
To: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Maxim Orlov <orlovmg@gmail.com>, Amul Sul <sulamul@gmail.com>,
	Bruce Momjian <bruce@momjian.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
Message-ID: <20221128183129.ip3g5vrcbjrngpp2@awork3.anarazel.de>
References: <20220706165110.GB2135371@nathanxps13>
 <20220811230921.GA1707962@nathanxps13>
 <20220824164624.GA1302727@nathanxps13>
 <20220902220744.GA1261322@nathanxps13>
 <20220923174154.GA1111614@nathanxps13>
 <20221106223842.GA620653@nathanxps13>
 <20221124001907.GA576983@nathanxps13>
 <CANbhV-EagKLoUH7tLEfg__VcLu37LY78F8gvLMzHrRZyZKm6sw@mail.gmail.com>
 <20221127233434.GA878043@nathanxps13>
 <CANbhV-GXQ+owyk_jnowFRJEVX1TDgQrnQrgQb6C87V6jTecpZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CANbhV-GXQ+owyk_jnowFRJEVX1TDgQrnQrgQb6C87V6jTecpZA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20221128183129.ip3g5vrcbjrngpp2%40awork3.anarazel.de>
Precedence: bulk

On 2022-11-28 13:08:57 +0000, Simon Riggs wrote:
> On Sun, 27 Nov 2022 at 23:34, Nathan Bossart <nathandbossart@gmail.com> wrote:
> > > Rather than explicitly use DEBUG1 everywhere I would have an
> > > #define CUSTODIAN_LOG_LEVEL     LOG
> > > so we can run with it in LOG mode and then set it to DEBUG1 with a one
> > > line change in a later phase of Beta
> >
> > I can create a separate patch for this, but I don't think I've ever seen
> > this sort of thing before.
> 
> Much of recovery is coded that way, for the same reason.

I think that's not a good thing to copy without a lot more justification than
"some old code also does it that way". It's sometimes justified, but also
makes code harder to read (one doesn't know what it does without looking up
the #define, line length).