Date: Tue, 29 Nov 2022 19:56:53 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Simon Riggs <simon.riggs@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Maxim Orlov <orlovmg@gmail.com>, Amul Sul <sulamul@gmail.com>,
	Bruce Momjian <bruce@momjian.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
Message-ID: <20221130035653.GA1594993@nathanxps13>
References: <20220923174154.GA1111614@nathanxps13>
 <20221106223842.GA620653@nathanxps13>
 <20221124001907.GA576983@nathanxps13>
 <CANbhV-EagKLoUH7tLEfg__VcLu37LY78F8gvLMzHrRZyZKm6sw@mail.gmail.com>
 <20221127233434.GA878043@nathanxps13>
 <CANbhV-GXQ+owyk_jnowFRJEVX1TDgQrnQrgQb6C87V6jTecpZA@mail.gmail.com>
 <20221128183129.ip3g5vrcbjrngpp2@awork3.anarazel.de>
 <CA+TgmoY55=uY=_vD-bQX4XjA0BWRC0JfVHTG=jPedXaPc+v4Mg@mail.gmail.com>
 <20221128234039.GA1119654@nathanxps13>
 <CANbhV-F3hKQCiHKP0gD2bECpcV7hyvF33_iiY_DeYaLgJgjMHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ"
Content-Disposition: inline
In-Reply-To: 
 <CANbhV-F3hKQCiHKP0gD2bECpcV7hyvF33_iiY_DeYaLgJgjMHA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20221130035653.GA1594993%40nathanxps13>
Precedence: bulk


--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 29, 2022 at 12:02:44PM +0000, Simon Riggs wrote:
> The last important point for me is tests, in src/test/modules
> probably. It might be possible to reuse the final state of other
> modules' tests to test cleanup, or at least integrate a custodian test
> into each module.

Of course.  I found some existing tests for the test_decoding plugin that
appear to reliably generate the files we want the custodian to clean up, so
I added them there.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--lrZ03NoBR/3+SXJZ
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v16-0001-Introduce-custodian.patch"