Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2ygj-0006yU-M9 for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Dec 2022 17:58:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p2ygi-0000Eq-Eq for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Dec 2022 17:58:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2ygi-0000Ef-5n for pgsql-hackers@lists.postgresql.org; Wed, 07 Dec 2022 17:58:32 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2ygf-000820-GA for pgsql-hackers@postgresql.org; Wed, 07 Dec 2022 17:58:31 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6621532009FC; Wed, 7 Dec 2022 12:58:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 07 Dec 2022 12:58:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1670435905; x=1670522305; bh=erUogddaaZ gygRuwAMmBoKomchcXxMIT9Wlr2MrWIlo=; b=JO9Bz9iUgyyUWkuGmSLRZ2e8wL F9ib4Ht1ACNZK11cUaAwqbytewm7EDmvCzmkuI2L8H/z1SlGl7rS1DOEfIRJoqBo yTCG0ua6cOpQDyXJrqzWUqgqzuJNWYroyqvxrt3+jov5FLx8/zQ5IA2l1h4tIH84 6E/Cyu5ghbjzTfx3LW7sBz7fZpsCVFtUbbIUTud0a20NCOQJh4J9KbLJzw3DO1Zf NXpmDqzmGI4zkq7Pn15/TxvPGw214pUNZYP0IxpBj/NykeAsxx8mPGRxgt9LN5hr plpG1cvrlZp3OsUzXtAIO7+HTpzeEoTrTRSQR/ehCjuZIAYWPYey6AtSkdhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1670435905; x=1670522305; bh=erUogddaaZgygRuwAMmBoKomchcX xMIT9Wlr2MrWIlo=; b=u9iGS+OL2T3LuIP6Pl1wadXDVv/N82gNrKwmqxlf2dye UHDbItsfNjyhNWslHPdyhG8yy99GEIlu/Dh+1bEBmR/4gPqu/lvvJCpecUIF5F3X uHjk+JpQLrg4Lr3Akg+9P79W3Ey/WpAY4PbICZHkexbBaBsJtu7oP4AumRodCub+ sKTRdwMLdi//raSry3cWENGb2hOq+ga5CJcedbkG+m+qvCqzsImLrWD5EPd2VX/a HgGwuPcawF0V2rMjTxMUfQcI1RiI24hKwHKyJmc0O2MofN9qiSmkbZ0Oxfb482+N i7GiP4t1ZCdAy8eM1nGAr222QxomZkFZ+dkNMKqE9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhephfegjedtudegveffteefjeeljedvgeetueelffdtffejgeffgeeggeff teegheeunecuffhomhgrihhnpegtihhrrhhushdqtghirdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgr iigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 12:58:25 -0500 (EST) Date: Wed, 7 Dec 2022 09:58:24 -0800 From: Andres Freund To: "Drouvot, Bertrand" Cc: Robert Haas , Alvaro Herrera , Ibrar Ahmed , Amit Khandekar , fabriziomello@gmail.com, tushar , Rahila Syed , pgsql-hackers Subject: Re: Minimal logical decoding on standbys Message-ID: <20221207175824.apmc5clnj2fdjkaq@awork3.anarazel.de> References: <2b14d595-1e8b-e5b6-6098-6a11d19fa1c7@amazon.com> <688cbedf-a172-f0d8-8352-d4ea223bceeb@amazon.com> <20211028210755.afmwcvpo6ajwdx6n@alap3.anarazel.de> <6711d09f-eaa9-264b-ec7f-88004218b075@amazon.com> <178cf7da-9bd7-e328-9c49-e28ac4701352@gmail.com> <4b19419f-2e7c-a76b-c948-26d10af6693d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b19419f-2e7c-a76b-c948-26d10af6693d@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-12-07 10:00:25 +0100, Drouvot, Bertrand wrote: > > Please find attached a new patch series: > > > > v27-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch > > v27-0002-Handle-logical-slot-conflicts-on-standby.patch > > v27-0003-Allow-logical-decoding-on-standby.patch > > v27-0004-New-TAP-test-for-logical-decoding-on-standby.patch > > v27-0005-Doc-changes-describing-details-about-logical-dec.patch > > v27-0006-Fixing-Walsender-corner-case-with-logical-decodi.patch This failed on cfbot [1]. The tap output [2] has the following bit: [09:48:56.216](5.979s) not ok 26 - cannot read from logical replication slot [09:48:56.223](0.007s) # Failed test 'cannot read from logical replication slot' # at C:/cirrus/src/test/recovery/t/034_standby_logical_decoding.pl line 422. ... Warning: unable to close filehandle GEN150 properly: Bad file descriptor during global destruction. Warning: unable to close filehandle GEN155 properly: Bad file descriptor during global destruction. The "unable to close filehandle" stuff in my experience indicates an IPC::Run process that wasn't ended before the tap test ended. Greetings, Andres Freund [1] https://cirrus-ci.com/task/5092676671373312 [2] https://api.cirrus-ci.com/v1/artifact/task/5092676671373312/testrun/build/testrun/recovery/034_standby_logical_decoding/log/regress_log_034_standby_logical_decoding