public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Time delayed LR (WAS Re: logical replication restrictions)
Date: Wed, 14 Dec 2022 10:35:02 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1+npWUVr78+vZWW19Z29GTN+7dmvUrmfQZnX6r2TFgXSg@mail.gmail.com>
References: <CAA4eK1Jg-KVAi5_WDj9pu1g_Uc_DHLxdU9ELnV_1ot-Sv6VvMg@mail.gmail.com>
	<[email protected]>
	<CAA4eK1+npWUVr78+vZWW19Z29GTN+7dmvUrmfQZnX6r2TFgXSg@mail.gmail.com>

At Tue, 13 Dec 2022 17:05:35 +0530, Amit Kapila <[email protected]> wrote in 
> On Tue, Dec 13, 2022 at 7:35 AM Kyotaro Horiguchi
> <[email protected]> wrote:
> >
> > At Mon, 12 Dec 2022 18:10:00 +0530, Amit Kapila <[email protected]> wrote in
> Yeah, I think ideally it will timeout but if we have a solution like
> during delay, we keep sending ping messages time-to-time, it should
> work fine. However, that needs to be verified. Do you see any reasons
> why that won't work?

Ah. I meant that "I have no clear idea of whether" by "I'm not sure".

I looked there a bit further. Finally ProcessPendingWrites() waits for
streaming socket to be writable thus no critical problem found here.
That being said, it might be better ProcessPendingWrites() refrain
from sending consecutive keepalives while waiting, 30s ping timeout
and 1h delay may result in 120 successive pings. It might not be a big
deal but..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (93+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Time delayed LR (WAS Re: logical replication restrictions)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox