Date: Wed, 14 Dec 2022 15:17:27 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Melih Mutlu <m.melihmutlu@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Message-ID: <20221214231727.GA828014@nathanxps13>
References: <2550453.1670974328@sss.pgh.pa.us>
 <20221214000145.GA638663@nathanxps13>
 <2561155.1670977214@sss.pgh.pa.us>
 <20221214004105.GA669835@nathanxps13>
 <20221214171023.GA689106@nathanxps13>
 <2707695.1671039752@sss.pgh.pa.us>
 <20221214174535.GA773264@nathanxps13>
 <2783450.1671042198@sss.pgh.pa.us>
 <20221214183759.GC773264@nathanxps13>
 <2787771.1671044578@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2787771.1671044578@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20221214231727.GA828014%40nathanxps13>
Precedence: bulk

On Wed, Dec 14, 2022 at 02:02:58PM -0500, Tom Lane wrote:
> Maybe we could have workers that are exiting for that reason set a
> flag saying "please restart me without delay"?

That helps a bit, but there are still delays when starting workers for new
subscriptions.  I think we'd need to create a new array in shared memory
for subscription OIDs that need their workers started immediately.

I'm not totally sure this is worth the effort.  These delays surface in the
tests because the workers are started so frequently.  In normal operation,
this is probably unusual, so the launcher would typically start new workers
immediately.  But if you and/or others feel this is worthwhile, I don't
mind working on the patch.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com