Date: Thu, 15 Dec 2022 09:52:34 +0100
From: Sandro Santilli <strk@kbt.io>
Sender: strk@kbt.io
To: Regina Obe <lr@pcorp.us>
Cc: 'Tom Lane' <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: Ability to reference other extensions by schema in extension
 scripts
Message-ID: <20221215085234.rpjzlm7hmsmbanqv@c19>
Mail-Followup-To: Sandro Santilli <strk@kbt.io>, Regina Obe <lr@pcorp.us>,
	'Tom Lane' <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
References: <003001d8f4ae$402282c0$c0678840$@pcorp.us>
 <79300.1668052170@sss.pgh.pa.us>
 <004501d8f4bf$1213fba0$363bf2e0$@pcorp.us>
 <175298.1668101858@sss.pgh.pa.us>
 <004b01d8fef3$752dbf30$5f893d90$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <004b01d8fef3$752dbf30$5f893d90$@pcorp.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20221215085234.rpjzlm7hmsmbanqv%40c19>
Precedence: bulk

On Tue, Nov 22, 2022 at 11:24:19PM -0500, Regina Obe wrote:

> Here is first version of my patch using the @extschema:extensionname@ syntax
> you proposed.
> 
> This patch includes:
> 1) Changes to replace references of @extschema:extensionname@ with the
> schema of the required extension
> 2) Documentation for the feature
> 3) Tests for the feature.
> 
> There is one issue I thought about that is not addressed by this.
> 
> If an extension is required by another extension and that required extension
> schema is referenced in the extension scripts using the
> @extschema:extensionname@ syntax, then ideally we should prevent the
> required extension from being relocatable.  This would prevent a user from
> accidentally moving the required extension, thus breaking the dependent
> extensions.
> 
> I didn't add that feature cause I wasn't sure if it was overstepping the
> bounds of what should be done, or if we leave it up to the user to just know
> better.

An alternative would be to forbid using @extschema:extensionname@ to
reference relocatable extensions. DBA can toggle relocatability of an
extension to allow it to be referenced.

--strk;