Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p73ER-0006gA-N6 for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Dec 2022 23:38:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p73EQ-0002tj-JP for pgsql-hackers@arkaria.postgresql.org; Sun, 18 Dec 2022 23:38:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p73EQ-0002tZ-57 for pgsql-hackers@lists.postgresql.org; Sun, 18 Dec 2022 23:38:10 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p73EO-00076H-5d for pgsql-hackers@postgresql.org; Sun, 18 Dec 2022 23:38:09 +0000 Received: by mail-il1-x131.google.com with SMTP id j28so4005742ila.9 for ; Sun, 18 Dec 2022 15:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=780m5vXmWKQ8QkQ+4JHrNnBk4zC8hq/1qqPsRgpcCdk=; b=q/u637RyTKAgpGFgVRaS2XZFuaeAZqoFCG2ooXnmVYPf5iC9JEnorPD/DL8A/atFih Hrl8ziK9pimmk72nhN8vbdbeWZOJFsLC7wUoZb5VsXBO1lcvmY/eE4ynCSlZ5UajJp1O OaTe2Yw7w7Un52uC5F8G02GrrHYDQQSHN7u7grCC8G1KlMqZHWMz4z5HlZk+ZQIcXDZG /L+cnWnWe+ORkXtkFeUo6gjg1U3vcQvQcKruDH484aEk0yensaoAw60/CQVtrKTfft9j X/qeos/oHZurvUK7D8d7XF+omCY0+O3g0mXWp3fRHzoaCcVy2BTRXS4D+PGQe5iOQGpL hP1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=780m5vXmWKQ8QkQ+4JHrNnBk4zC8hq/1qqPsRgpcCdk=; b=yFlRpz9pvY7D6ZMbRvfYtJko1xdfnrFN7ido5ogdlBcncz44WL3tB74h7TArCu8lUd h/CbPMGlIxhQKMkIDTbv4GKZatjri/K+3AImyQHw0ap6bahhYc/NQGovuq6zycTrlcmO aJ8rrjBeowQqJXzZkuYBEkedkq8/QWPhrm1RazJ4gl1P1pM35eIZ+IqHGAY5h5IArc0m 0vkVmsDVuFK/sGe1g+hHsJkXTDlB4iM35MU/dBxp+C+8ZBQeZRRL0/p6tU2lNWo4I10Q JNOEDQRnHQlZzkL2WMHzhBSNr5UZRodulZ4UeT4xPe4Bk6IXX9afvnR1TIVlLHfArHIn Yh7w== X-Gm-Message-State: ANoB5pnfSXL73sJnIlR1ri5C4M63rbxR5w2vznhZkISTy2UgCBuUR3Ec sBhWhl/ov5MjulzeDHya31UvZA== X-Google-Smtp-Source: AA0mqf7RPo9lONfpcNPmTaTRS/Fkuntb7SJVlLZVNJRM4m7UqYOiXZNGCPJF+N9dRmbCNeJUjfQo7Q== X-Received: by 2002:a92:7b0d:0:b0:302:e4c8:dace with SMTP id w13-20020a927b0d000000b00302e4c8dacemr17235550ilc.22.1671406686083; Sun, 18 Dec 2022 15:38:06 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id g6-20020a02a086000000b00375217ea9b6sm2864332jah.45.2022.12.18.15.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 15:38:05 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 968D3800A36; Sun, 18 Dec 2022 17:38:03 -0600 (CST) Date: Sun, 18 Dec 2022 17:38:03 -0600 From: Justin Pryzby To: Ted Yu Cc: Nathan Bossart , Jeff Davis , Pavel Luzanov , pgsql-hackers@postgresql.org Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX Message-ID: <20221218233803.GW1153@telsasoft.com> References: <20221214032332.GA671806@nathanxps13> <8f7172da-2b58-3bd0-97ae-5126e2a7970c@postgrespro.ru> <20221214221140.GA1153@telsasoft.com> <295e86c7aeafb8e2623f8eccdc846855bf2c7e0c.camel@j-davis.com> <20221217060408.GA1256247@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Dec 17, 2022 at 04:39:29AM -0800, Ted Yu wrote: > + List *ancestors = get_partition_ancestors(relid); > + Oid root = InvalidOid; > > nit: it would be better if the variable `root` can be aligned with variable > `ancestors`. It is aligned, but only after configuring one's editor/pager/mail client to display tabs in the manner assumed by postgres' coding style.