Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7hEE-0007Mp-P6 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Dec 2022 18:20:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p7hED-000364-Na for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Dec 2022 18:20:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7hCq-0007ZD-6n for pgsql-hackers@lists.postgresql.org; Tue, 20 Dec 2022 18:19:12 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7hCj-0004Yr-QQ for pgsql-hackers@postgresql.org; Tue, 20 Dec 2022 18:19:11 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 75CB23200979; Tue, 20 Dec 2022 13:19:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 20 Dec 2022 13:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1671560341; x=1671646741; bh=b8i6qBUIhX vpUmeR337+dxv7U0pdmLZ4hsraw6M/3Ro=; b=fGGe7EezFdCXMzKge6WqKPtnfW MaBCfK6KhFH7zvjE5y4ZYHaQok4F2J4s2ppEsLuT8LSOzgI7+8W1u/fUmzSXTlU2 mzEQryiKVWXv84+A1j9wBSMsTlxXDDfdTSLwQaV3gdE6obqsWdRkF98CsrdmQVRy 0LodCBGbapMG+g7GqMmp1ZmkSkVGrPKWixKgFXgrxg397IiIFJulgxuWXGOxTpjT ItTfnpveTLr/5YFXzlxZ3WfcEqOANTFRHL5EgavkhpKSPPu+hJFMz5vCV6+vitzG +TK6lNapeqw/H3rs2EOEn2CNh1O7zvYGt9rzKPpDJLBHEtVttjapGJfb2D7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671560341; x=1671646741; bh=b8i6qBUIhXvpUmeR337+dxv7U0pd mLZ4hsraw6M/3Ro=; b=V/LE8Wug1NDBQIMfksoG6+Atm6m6FrbK8xpScGa9IzA9 ccte6TlBk4eHs9weqbDctIrnyAiTaV+rWhI8NWCuJ+Xfe76QIADrwyidJ/hEyjIn NMkjwaSPqPTLbMiZWwzGEkVnBZB7POPt1qGlY269FlvQ/wHe5GY4vSYJMeZkeUtK bipi+jDWtxzKEENIM+g9toRu0PvawFrO9aieDVv9wtAJnR6IM0d2V71pcTdGbWRO CeZLWDrWC2JJhPRwkH/pu9b6FLk4hcsCx85CqLtgPkxTYd8ru+zaeGZSWmC/MmBA ArU1Sid751ZZUdP/ufNnicYFrXvCiluLCXFRl9UvNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeigdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteevudei tedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Dec 2022 13:19:00 -0500 (EST) Date: Tue, 20 Dec 2022 09:56:02 -0800 From: Andres Freund To: Robert Haas Cc: "Drouvot, Bertrand" , Alvaro Herrera , Ibrar Ahmed , Amit Khandekar , fabriziomello@gmail.com, tushar , Rahila Syed , pgsql-hackers Subject: Re: Minimal logical decoding on standbys Message-ID: <20221220175602.tva63nriepj33lau@alap3.anarazel.de> References: <9f0a021e-40e1-0ae6-8086-a4457c99749e@gmail.com> <0ae83e69-bda0-0eb8-ef4a-d169292e3f66@gmail.com> <47f5faf0-6a6d-602a-5d5b-9449ca74c6ad@gmail.com> <60a6476d-f799-39ff-7cd6-98b2665a2c0b@gmail.com> <20221216135158.qdzftmbli6kwjzle@alap3.anarazel.de> <8df4d682-0948-179c-f134-1cc5edd73560@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-12-16 11:38:33 -0500, Robert Haas wrote: > On Fri, Dec 16, 2022 at 10:08 AM Drouvot, Bertrand > wrote: > > > After 1489b1ce728 the name mayConflictInLogicalDecoding seems odd. Seems > > > it should be a riff on snapshotConflictHorizon? > > > > Gotcha, what about logicalSnapshotConflictThreat? > > logicalConflictPossible? checkDecodingConflict? > > I think we should try to keep this to three words if we can. There's > not likely to be enough value in a fourth word to make up for the > downside of being more verbose. I don't understand what the "may*" or "*Possible" really are about. snapshotConflictHorizon is a conflict with a certain xid - there commonly won't be anything to conflict with. If there's a conflict in the logical-decoding-on-standby case, we won't be able to apply it only sometimes or such. How about "affectsLogicalDecoding", "conflictsWithSlots" or "isCatalogRel" or such? Greetings, Andres Freund