Date: Mon, 26 Dec 2022 14:39:03 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	David Christensen <david.christensen@crunchydata.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Message-ID: <20221226203903.GT1153@telsasoft.com>
References: 
 <CAOxo6XLhduEAn0yLh+BGOjpq6k0x9MsOY6PjDEoCh4VvdUxCiQ@mail.gmail.com>
 <CALj2ACWmgbDeCDMaZah0GRwQBCJMD01U4S69V6TE4W2jYmnLuQ@mail.gmail.com>
 <CAOxo6XJMcLyLb1D4oOV2FHfJvt1Z6DuediGUKKEHAEMvpPe2ow@mail.gmail.com>
 <Y5rAViBOVChfrsHN@paquier.xyz>
 <CAOxo6X+NCVAB3H5_TMSasgimf127KURoi=S0dTSNJUn8Z8+WNA@mail.gmail.com>
 <CALj2ACUT+DB8PhF6ja8f-LP76cEappXrJuhzrKd81a90UmrnYA@mail.gmail.com>
 <CAOxo6XLhKqiacFPSo2BhZU6Qwwy3wDEsVjPmTsgHz9Pr-aVyUg@mail.gmail.com>
 <CAOxo6XJyYZdiEsF5r3+h1BSPprQ6+8=a4EgNiePWQjyFaafdZw@mail.gmail.com>
 <CALj2ACVwNiSNKFjZ+Wr2a+Wwqt9ELCQeFXTWNqf8s8eOZSd7Ew@mail.gmail.com>
 <Y6lNNN1sTWsOpGcK@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y6lNNN1sTWsOpGcK@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20221226203903.GT1153%40telsasoft.com>
Precedence: bulk

On Mon, Dec 26, 2022 at 04:28:52PM +0900, Michael Paquier wrote:
> Comments?

> +		file = fopen(filename, PG_BINARY_W);
> +		if (!file)
> +			pg_fatal("could not open file \"%s\": %m", filename);
> +
> +		if (fwrite(page, BLCKSZ, 1, file) != 1)
> +			pg_fatal("could not write file \"%s\": %m", filename);
> +
> +		fclose(file);

fclose() should be tested, too:

> +		if (fwrite(page, BLCKSZ, 1, file) != 1 || fclose(file) != 0)
> +			pg_fatal("could not write file \"%s\": %m", filename);

-- 
Justin