Feedback-ID: id4a34324:Fastmail
Date: Tue, 27 Dec 2022 12:12:32 -0800
From: Andres Freund <andres@anarazel.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"smithpb2250@gmail.com" <smithpb2250@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Force streaming every change in logical decoding
Message-ID: <20221227201232.ofhkyancsti24p7l@awork3.anarazel.de>
References: 
 <CAA4eK1KFRdPSGnkHSoR1T+Z08XsaL12fX8xMj_ZpAR6LR+RJYQ@mail.gmail.com>
 <20221222.164507.1962968929109173863.horikyota.ntt@gmail.com>
 <CAA4eK1LdqfKHcSDx_C1dZf9To0PJX1DT2zU91MPLjHebN+8GOQ@mail.gmail.com>
 <OSZPR01MB631072993E90DB0397FD1C49FDE89@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAA4eK1+VoADvUJ2MdhDSTJuUptsjV=ZRNWKAwVhAOLc2=5u2kg@mail.gmail.com>
 <OSZPR01MB6310CA947F7DBFD8F12636D4FDE99@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CAD21AoBQBhpyF2yPTZr=bsLOC75tVSf01PMUc+DHacBMEERzqA@mail.gmail.com>
 <CAA4eK1KgmRj_tS8-Rq4yt_2RQTY+SAZx0fHyHYYrn44=nsExKQ@mail.gmail.com>
 <CAFiTN-txXL+EXh=pnNiL_7cagUpHrZ_4Kf7VX4bdGYE2GBAMAg@mail.gmail.com>
 <CAA4eK1+Nc1Z-QjV-Dawv6oDfx4GxJ49eBvc8F_AuRwhVuxHY1w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1+Nc1Z-QjV-Dawv6oDfx4GxJ49eBvc8F_AuRwhVuxHY1w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20221227201232.ofhkyancsti24p7l%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-12-26 14:04:28 +0530, Amit Kapila wrote:
> Pushed.

I did not follow this thread but saw the commit. Could you explain why a GUC
is the right mechanism here? The commit message didn't explain why a GUC was
chosen.

To me an option like this should be passed in when decoding rather than a GUC.

Greetings,

Andres Freund