Feedback-ID: id4a34324:Fastmail
Date: Thu, 29 Dec 2022 13:40:13 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>,
	Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement
 -Wshadow=compatible-local
Message-ID: <20221229214013.y5i3ovlrhrc2dbaj@awork3.anarazel.de>
References: <e5e13d55-8c8b-30a6-0b13-0304a3e562dd@enterprisedb.com>
 <20221102234346.zcupk5mqysavci4t@awork3.anarazel.de>
 <1881935.1667433465@sss.pgh.pa.us>
 <20221103000334.sbh5jqw37i3y7pc3@awork3.anarazel.de>
 <20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de>
 <356473.1672253007@sss.pgh.pa.us>
 <20221229000223.2pdwxexfrgoximul@awork3.anarazel.de>
 <438139.1672272335@sss.pgh.pa.us>
 <20221229184236.3v7bvsumefpslq7h@awork3.anarazel.de>
 <586729.1672339897@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <586729.1672339897@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20221229214013.y5i3ovlrhrc2dbaj%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-12-29 13:51:37 -0500, Tom Lane wrote:
> We might find that some GCC-impostor compilers have trouble with it,
> but if so we can adjust the #ifdef here.

Yea. I suspect it's widely enough used that any compiler claiming to be gcc
compatible has it, but ...


> Getting nitpicky, I suggest calling it "HAVE_PRAGMA_GCC_SYSTEM_HEADER"
> to align better with what you actually have to write.

Makes sense.


> + * Newer versions the perl headers trigger a lot of warnings with our compiler
> 
> "Newer versions of ..." please.  Otherwise LGTM.

Oops.


> > Should we backpatch this? Given the volume of warnings it's probably a good
> > idea. But I'd let it step in HEAD for a few days of buildfarm coverage first.
> 
> +1 to both points.

Pushed to HEAD.

Greetings,

Andres Freund