Date: Sat, 31 Dec 2022 15:50:19 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Melih Mutlu <m.melihmutlu@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Message-ID: <20221231235019.GA1223171@nathanxps13>
References: <20221214004105.GA669835@nathanxps13>
 <20221214171023.GA689106@nathanxps13>
 <2707695.1671039752@sss.pgh.pa.us>
 <20221214174535.GA773264@nathanxps13>
 <2783450.1671042198@sss.pgh.pa.us>
 <20221214183759.GC773264@nathanxps13>
 <2787771.1671044578@sss.pgh.pa.us>
 <20221214231727.GA828014@nathanxps13>
 <20221215224721.GA694065@nathanxps13>
 <20221218233607.GB1476904@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv"
Content-Disposition: inline
In-Reply-To: <20221218233607.GB1476904@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20221231235019.GA1223171%40nathanxps13>
Precedence: bulk


--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Dec 18, 2022 at 03:36:07PM -0800, Nathan Bossart wrote:
> This seems to have somehow broken the archiving tests on Windows, so
> obviously I owe some better analysis here.  I didn't see anything obvious
> in the logs, but I will continue to dig.

On Windows, WaitForWALToBecomeAvailable() seems to depend on the call to
WaitLatch() for wal_retrieve_retry_interval to ensure that signals are
dispatched (i.e., pgwin32_dispatch_queued_signals()).  My first instinct is
to just always call WaitLatch() in this code path, even if
wal_retrieve_rety_interval milliseconds have already elapsed.  The attached
0003 does this.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--ZGiS0Q5IWpPtfppv
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v10-0001-wake-up-logical-workers-as-needed-instead-of-rel.patch"