Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pCUW1-00058e-3X
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Jan 2023 23:46:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pCUVy-0002j8-50
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Jan 2023 23:46:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pCUVw-0002iz-7l
	for pgsql-hackers@lists.postgresql.org; Mon, 02 Jan 2023 23:46:45 +0000
Received: from out3-smtp.messagingengine.com ([66.111.4.27])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pCUVs-0004yf-HJ
	for pgsql-hackers@postgresql.org; Mon, 02 Jan 2023 23:46:43 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.nyi.internal (Postfix) with ESMTP id C820B5C0098;
	Mon,  2 Jan 2023 18:46:38 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
  by compute5.internal (MEProxy); Mon, 02 Jan 2023 18:46:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to; s=fm2; t=1672703198; x=1672789598; bh=2YVJi3p+Ao
	6PRvAL6UYXknNWtsQZ/4FRD73vqo4DmbA=; b=xzBA3bwoQfaMTT7/J0F/5uMZuv
	djPiGKLr6xb7ftYePaRW68zpWu8GcDXfTozETswjbxZWyV4yiBF3WJJnHruO6+/Z
	HS4P25AKgkwGzGdEXCOMpwT+EzLpber3oSU4wb+PbqQB5gwJudoABW8lclrSM/Zg
	7P92+32QHpe03Y47yM8Bh2ptokADSMtFk/MmEHk9QAl7fnXd3mj4rXBisk/ouwby
	8R5jRFANznHfb35TKlahWOEJ+6WLml4yC/HTzY8oBfMR2t0/4/1fD/bJaNde5Zcu
	QFn+P6y0GGi9fO918C2QcRb4Qngxr7BGYX+R40OM/69MSGzAy7dVcebwBAuw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1672703198; x=1672789598; bh=2YVJi3p+Ao6PRvAL6UYXknNWtsQZ
	/4FRD73vqo4DmbA=; b=Iu5tFU/uE04fW4LhMKghlYLnGWP0h2L74WKSiSAv3r4P
	c0FvoE4BguskQM5AI3Ssd3CxBIgiWa6h/3XqXvzKJUlmeDF9iIOq5XXW8R3vPjAJ
	qCz/S5OvZlpeQW7l7w/YpQ4GXueMDDbeM3zg5hvTJNcENE3znrQ5G7T2e63RDdyv
	9Ikg+mjl4T0HLHUNBMcmMj1Uoyt4BTLT+Q878K3XyxTfbKHTAOF+caJEaWd8EZ5B
	R2muaBYx3KUXz3Hr76R9T5Pdj1qk5k0PVKKnyWWRbv29fIlTdS//CO16Rdb5OwkB
	nhLaW1AtGFJahHevktEORLbc3eQDox45UnKeaEe+7g==
X-ME-Sender: <xms:3myzY3zHtJ7IWkUQPN2KUHzL9-wrJkW-jIl_H3whnF9NxE-vIkPT0A>
    <xme:3myzY_RzeLSleUT-ZPZwwwd-3xvXwothe1o5Th7eEtIXvYKUrSFDxXEJbEhuF4KZd
    7WD1XqYK3ObA9wvPQ>
X-ME-Received: <xmr:3myzYxXvxoNQUZaJhDvSOXMvRLwvJzfRrP-75XH8VaqrvKvu5BFxgL2dnnf83eIQDyCY_hQpf83LU7PH19Sg6gL692R2myDAT73pvOOvQy7PH8FapOngbEhreQ-9>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeefgddugecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv
    shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg
    htthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteevudei
    tedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
    grnhgurhgvshesrghnrghrrgiivghlrdguvg
X-ME-Proxy: <xmx:3myzYxgWwLgHbxpSMd--JlvW56-R0_jjXHsYP2off3wHfFPi4bwAew>
    <xmx:3myzY5C8BqifqHGOmU9IxPQxaM1MmCR4MAqPihPnCKp8d8J_xpwUBw>
    <xmx:3myzY6JF7s2RV3aOpdkI236yngy3a46EKZpoUVk7wS48qpvcIQoYYg>
    <xmx:3myzY4P9CB3aDD1Z_bAS_7vxNW7RkNob6ZRbBsiosp2xC-wurHybhQ>
Feedback-ID: id4a34324:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 2 Jan 2023 18:46:38 -0500 (EST)
Date: Mon, 2 Jan 2023 15:46:36 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>,
	Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>
Subject: Re: perl 5.36, C99, -Wdeclaration-after-statement
 -Wshadow=compatible-local
Message-ID: <20230102234636.pjjverdgenv64qvl@awork3.anarazel.de>
References: <20221102234346.zcupk5mqysavci4t@awork3.anarazel.de>
 <1881935.1667433465@sss.pgh.pa.us>
 <20221103000334.sbh5jqw37i3y7pc3@awork3.anarazel.de>
 <20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de>
 <356473.1672253007@sss.pgh.pa.us>
 <20221229000223.2pdwxexfrgoximul@awork3.anarazel.de>
 <438139.1672272335@sss.pgh.pa.us>
 <20221229184236.3v7bvsumefpslq7h@awork3.anarazel.de>
 <586729.1672339897@sss.pgh.pa.us>
 <20221229214013.y5i3ovlrhrc2dbaj@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221229214013.y5i3ovlrhrc2dbaj@awork3.anarazel.de>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20230102234636.pjjverdgenv64qvl%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-12-29 13:40:13 -0800, Andres Freund wrote:
> > > Should we backpatch this? Given the volume of warnings it's probably a good
> > > idea. But I'd let it step in HEAD for a few days of buildfarm coverage first.
> > 
> > +1 to both points.
> 
> Pushed to HEAD.

I haven't seen any problems in HEAD, so I'm working on backpatching.

Greetings,

Andres Freund