Feedback-ID: id4a34324:Fastmail
Date: Wed, 4 Jan 2023 14:16:50 -0800
From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Robert Haas <robertmhaas@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Is RecoveryConflictInterrupt() entirely safe in a signal handler?
Message-ID: <20230104221650.ig6c5hg3325neb7s@awork3.anarazel.de>
References: <20220523001001.aecggmoc5mowevuw@alap3.anarazel.de>
 <YqlzXhqD6gfByxh7@paquier.xyz>
 <CA+TgmoZMrmjyaxsA=ozXbRXAWWns4AtQ6HBCZHH=m1uPc+dR4Q@mail.gmail.com>
 <CA+hUKGKrLKx7Ky1T_FHk-Y729K0oie-gOXKCbxCXyjbPDJAOOw@mail.gmail.com>
 <20220622023301.pwgy2tsxcc2ypzao@alap3.anarazel.de>
 <20220701201423.sic5b77ei3atjbes@alap3.anarazel.de>
 <20220701231833.vh76xkf3udani3np@alap3.anarazel.de>
 <CA+hUKG+V3Rd3F-H_+8RFVmm6PV6o1U0uU6dNQNWHqmq95ojxwA@mail.gmail.com>
 <2624973.1658877772@sss.pgh.pa.us>
 <20221229084052.GA1514070@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221229084052.GA1514070@rfd.leadboat.com>
Archived-At: <https://www.postgresql.org/message-id/20230104221650.ig6c5hg3325neb7s%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-12-29 00:40:52 -0800, Noah Misch wrote:
> Incidentally, the affected test contains comment "# DROP TABLE containing
> block which standby has in a pinned buffer".  The standby holds no pin at
> that moment; the LOCK TABLE pins system catalog pages, but it drops every
> pin it acquires.

I guess that comment survived from an earlier version of that test (or another
test where it was copied from).

I'm inclined to just delete it.

Greetings,

Andres Freund