Date: Sat, 7 Jan 2023 19:56:08 -0600
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Daniel Gustafsson
 <daniel@yesql.se>, Robert Haas <robertmhaas@gmail.com>, Andres Freund
 <andres@anarazel.de>, Devrim =?UTF-8?B?R8O8bmTDvHo=?= <devrim@gunduz.org>,
 Joe Conway <mail@joeconway.com>, PostgreSQL Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: drop postmaster symlink
Message-ID: <20230107195608.3f770868@slate.karlpinc.com>
In-Reply-To: <3492787.1673134705@sss.pgh.pa.us>
References: <ece84b69-8f94-8b88-925f-64207cb3a2f0@enterprisedb.com>
	<252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com>
	<6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org>
	<3705500.1669216069@sss.pgh.pa.us>
	<20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de>
	<CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
	<FBFE437E-B089-494B-9A36-4E3290CFF514@yesql.se>
	<20230107165942.748ccf4e@slate.karlpinc.com>
	<3492787.1673134705@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230107195608.3f770868%40slate.karlpinc.com>
Precedence: bulk

On Sat, 07 Jan 2023 18:38:25 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> "Karl O. Pinc" <kop@karlpinc.com> writes:
> > This is a review of Peter's 2 patches.  I see only 1 small problem.
> >  
> 
> > Looking at the documentation, a "postmaster" in the glossary is
> > defined as the controlling process.  This works; it needs to be
> > called something.  There is still a postmaster.pid (etc.) in the
> > data directory.  
> 
> > The word "postmaster" (case insensitive) shows up 84 times in the
> > documentation.  I looked at all of these.    
> 
> Hmm ... I thought this patch was about getting rid of the
> admittedly-obsolete installed symlink.  If it's trying to get rid of
> the "postmaster" terminology for our parent process, I'm very strongly
> against that, either as regards to code or documentation.

No.  It's about getting rid of the symlink.  I was grepping around
to look for use of the symlink, started with the glossary just
to be sure, and saw that "postmaster" is consistently (I think)
used to refer to the controlling, parent, process.  And wrote
down what I was doing and what I found as I went along.  And then
sent out my notes.

Sorry for the confusion.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein